Deck card sharing - success message typo

[gerbrent]

How to use GitHub

• Please use the 👍 reaction to show that you are affected by the same issue.
• Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
• Subscribe to receive notifications on status change and new comments.

---

Summary

When sharing a Deck card from Deck to a Talk conversation via the "Post to a conversation" feature, the success message contains a typo Deck card has been posted to the selectedconversation

The offending line appears to be here - though... no obvious culprit here (at least to a lamens like me)

Steps to reproduce

1. From within Deck, share a card using "Post to a conversation" feature
2. Success message appears, but with typo

Expected behaviour

Tell us what should happen

Should read "...selected conversation"

Actual behaviour

success message contains a typo Deck card has been posted to the selectedconversation

Talk app

no access to admin

Talk app version: (see apps admin page: /index.php/settings/apps)

Custom Signaling server configured: yes/no and version (see additional admin settings: /index.php/index.php/settings/admin/talk#signaling_server)

Custom TURN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#turn_server)

Custom STUN server configured: yes/no (see additional admin settings: /index.php/settings/admin/talk#stun_server)

Browser

Microphone available: yes/no

Camera available: yes/no

Operating system: Windows/Ubuntu/...
openSUSE Tumbleweed

Browser name: Firefox/Chrome/...
Firefox

Browser version: 85/96/...
116.0.2

Browser log

``` Insert your browser log here, this could for example include: a) The javascript console log b) The network log c) ... ```

Server configuration

cloud.nextcloud.com

Operating system: Ubuntu/RedHat/...

Web server: Apache/Nginx

Database: MySQL/Maria/SQLite/PostgreSQL

PHP version: 8.0/8.1/8.2

Nextcloud Version: (see admin page)

List of activated apps:

If you have access to your command line run e.g.:
sudo -u www-data php occ app:list
from within your server installation folder

Nextcloud configuration:

If you have access to your command line run e.g.:
sudo -u www-data php occ config:list system
from within your Nextcloud installation folder

Server log (data/nextcloud.log)

Insert your server log here

[nickvergessen]

Space is there:

spreed/src/deck.js

Line 48 in 6bd07be

showSuccess(t('spreed', 'Deck card has been posted to the selected <a href="{link}">conversation</a>', {

I fear it's a problem of the HTML option in the showSuccess function of the @nextcloud/dialogs library then?

[nickvergessen]

In the meantime this seems to have broken completely:

[juliusknorr]

Fix is in nextcloud/deck#5351

[juliusknorr]

Regarding the initial report, the toast works fine here with the deck fix and latest talk main branch: