fix: Get proper rich object for card actions #5351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <[email protected]>
juliushaertl
force-pushed
the
bugfix/noid/card-actions
branch
from
a5577e6
to
b06b41f
Compare
nickvergessen
approved these changes
Dec 6, 2023
|
/backport to stable28 |
This was referenced Dec 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When moving over the card actions to a different component the computed
cardRichObjectwas missing.The actions are now covered with a test case registering a dummy action and asserting that its callback gets triggered with the expected result rich object when clicking the action.
We should think about enabling vue/no-undef-properties as eslint rule which could have catched this but unfortunately it throws a lot of unrelated errors with vuex mapGetters/mapState methods.