getting default timezone for local time #49087
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
In the server/lib/base.php file of the Nextcloud server, UTC is always set as the default timezone:
server/lib/base.php
Line 609 in 4a44d6a
The main argument for this choice seems to be to simplify log reading, as discussed in this issue: #3553.
However, this hardcoding of UTC affects all instances where date_default_timezone_get is used, resulting in UTC even when it would be more intuitive to use the server's timezone or the one set in config.php under default_timezone.
This pull request resolves an issue in the contact menu where the timezone was unexpectedly set to UTC. The fix aligns with other parts of the system that correctly retrieve the default timezone by leveraging similar logic:
https://github.com/search?q=org%3Anextcloud+%22%3EgetDefaultTimeZone%28%22&type=code
TODO
Checklist