Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: expand select and group by for calendar reminder backend #47399

Merged
merged 1 commit into from
Sep 19, 2024
Merged

fix: expand select and group by for calendar reminder backend #47399

merged 1 commit into from
Sep 19, 2024
+10 −8

Conversation

hamza221
Copy link
Contributor

@hamza221 hamza221 commented Aug 21, 2024 •
edited
Loading

Checklist

@miaulalala
Copy link
Contributor

apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php:115 - I think you might need the id column after all but I haven't looked into it. LMK if you want to do a debugging call.

ChristophWurst

This comment was marked as outdated.

Sign in to view

@ChristophWurst ChristophWurst mentioned this pull request Sep 15, 2024
Closed
4 tasks
@ChristophWurst
Copy link
Member

/backport to stable30

@solracsf
Copy link
Member 

There was 1 error:

1) OCA\DAV\Tests\unit\CalDAV\Reminder\BackendTest::testGetRemindersToProcess
Undefined array key "id"

/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Backend.php:191
/home/runner/actions-runner/_work/server/server/apps/dav/lib/CalDAV/Reminder/Backend.php:57
/home/runner/actions-runner/_work/server/server/apps/dav/tests/unit/CalDAV/Reminder/BackendTest.php:115

@solracsf solracsf mentioned this pull request Sep 17, 2024
Closed
8 tasks
@miaulalala
Copy link
Contributor

This change fails for me with share notifications

@solracsf solracsf self-requested a review September 17, 2024 17:01
@solracsf solracsf added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Sep 17, 2024
@solracsf solracsf removed their request for review September 17, 2024 17:02
@hamza221 hamza221 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Sep 18, 2024
ChristophWurst
ChristophWurst approved these changes Sep 18, 2024
View reviewed changes
Copy link
Member

@ChristophWurst ChristophWurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with ONLY_FULL_GROUP_BY on in mariadb. Master fails, this works

👍

@hamza221
Copy link
Contributor Author

Tested with ONLY_FULL_GROUP_BY on in mariadb. Master fails, this works

👍

Other tests are failing now, after rebase

@solracsf
Copy link
Member

I've previously submitted a, perhaps, less error-prone PR here (closed because this one was older) : #47996

@miaulalala miaulalala mentioned this pull request Sep 19, 2024
Closed
8 tasks
@ChristophWurst ChristophWurst added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Sep 19, 2024
@hamza221 hamza221 merged commit 34445ea into master Sep 19, 2024
175 checks passed
@hamza221 hamza221 deleted the fix/47275/driverException branch September 19, 2024 14:57
@backportbot backportbot bot mentioned this pull request Sep 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChristophWurst ChristophWurst ChristophWurst approved these changes

@solracsf solracsf solracsf approved these changes

@miaulalala miaulalala Awaiting requested review from miaulalala miaulalala is a code owner

@tcitworld tcitworld Awaiting requested review from tcitworld tcitworld is a code owner

Assignees

@hamza221 hamza221

Labels
4. to release Ready to be released and/or waiting for tests to finish bug regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: DriverException during BackgroundJob
4 participants
@hamza221 @miaulalala @ChristophWurst @solracsf