Add small font size variable #46925
Merged
Add small font size variable #46925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Antreesy
approved these changes
Jul 31, 2024
|
|
This is needed to create a bit more hyerarchy between more important and less important text. For example for the talk conversation description in the header or in NcListItem's "subname" Signed-off-by: Marco Ambrosini <[email protected]>
marcoambrosini
force-pushed
the
feat/add-small-font-size-variable
branch
from
50909f3
to
9855485
Compare
susnux
approved these changes
Jul 31, 2024
susnux
reviewed
Jul 31, 2024
| @@ -49,6 +49,7 @@ | |||
| --color-border-maxcontrast: #7d7d7d; | |||
| --font-face: system-ui, -apple-system, 'Segoe UI', Roboto, Oxygen-Sans, Cantarell, Ubuntu, 'Helvetica Neue', 'Noto Sans', 'Liberation Sans', Arial, sans-serif, 'Apple Color Emoji', 'Segoe UI Emoji', 'Segoe UI Symbol', 'Noto Color Emoji'; | |||
| --default-font-size: 15px; | |||
| --font-size-small: 13px; | |||
There was a problem hiding this comment.
Maybe use 12px as that is the currently smallest font size we need to use (and fits the grid baseline)
There was a problem hiding this comment.
It seemed too small compared to the default one and looked odd when both are used in the same component (e.g.) Line and subline. I think we should bring all the 12px instances up to 13 for now.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.