fix(files): disallow illegal characters

[skjnldsv]

fix #38614

[susnux]

I disagree here, just because one system (Window) can not handle those symbols we should not hard forbid it here.
E.g. I often use some of those.

See also the git blame of OCP\Constants::FILENAME_INVALID_CHARS.

Especially we should not have multiple different character lists that we forbid, I would simply use OCP\Constants::FILENAME_INVALID_CHARS and maybe make if configurable to forbid more (system config value?)

[skjnldsv]

See also the git blame of OCP\Constants::FILENAME_INVALID_CHARS.

Especially we should not have multiple different character lists that we forbid, I would simply use OCP\Constants::FILENAME_INVALID_CHARS and maybe make if configurable to forbid more (system config value?)

Nice, I search for this, and I could only find a variable in files_external, which would ot have been proper to use.

I disagree here, just because one system (Window) can not handle those symbols we should not hard forbid it here.

I don't think that's a big of an issue to be honest, but I agree with you.
What shall we do then? Close the other issue?

EDIT

BTW, linux have a bit more than just /
https://stackoverflow.com/a/31976060/3885878

Also, it seems many people do recommend to refrain from using some.

EDIT2

Do we actually support windows officially? If not, I would then close the other issue.
The only option I see if adding a config variable so people can use it 🤔
cc @ChristophWurst @nickvergessen @juliushaertl @icewind1991

[nickvergessen]

Do we actually support windows officially?

Not as server plattform.

But it's of course still bad UX when people create such files on ubuntu/mac and then share with windows users.

The list you have matches the old value of the constant:
6bd0d51

So I would say the only disallowed chars are / and \ so you can use the const.

Some external storages have more restrict limits (SMB?), but I'd say it's fine to not block that in the UI in the beginning and just show an error afterwards.

[skjnldsv]

So I would say the only disallowed chars are / and \ so you can use the const.

The const is a weird format though. It should be an array of string, not a string...
Especially the var name is confusing, being plural 🙈

[nickvergessen]

It should be an array of string, not a string...

We have been growing a long way. It simply was not allowed in PHP until 5.6

[skjnldsv]

Done! Please review :)

[susnux]

Very nice solution 👍