Refactor files_sharing app commands #39898
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 16, 2023 10:45
To improve code readability. Signed-off-by: Faraz Samapoor <[email protected]>
To improve code readability. Signed-off-by: Faraz Samapoor <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| } | ||
|
|
||
| public function countFiles($numericId, OutputInterface $output) { | ||
| public function countFiles($numericId, OutputInterface $output): void { |
Check notice
Code scanning / Psalm
MissingParamType Note
| @@ -118,7 +112,7 @@ | |||
| $output->writeln("$count files can be deleted for storage $numericId"); | |||
| } | |||
|
|
|||
| public function deleteStorage($id, $numericId, OutputInterface $output) { | |||
| public function deleteStorage($id, $numericId, OutputInterface $output): void { | |||
Check notice
Code scanning / Psalm
MissingParamType Note
| @@ -118,7 +112,7 @@ | |||
| $output->writeln("$count files can be deleted for storage $numericId"); | |||
| } | |||
|
|
|||
| public function deleteStorage($id, $numericId, OutputInterface $output) { | |||
| public function deleteStorage($id, $numericId, OutputInterface $output): void { | |||
Check notice
Code scanning / Psalm
MissingParamType Note
| @@ -132,7 +126,7 @@ | |||
| $this->deleteFiles($numericId, $output); | |||
| } | |||
|
|
|||
| public function deleteFiles($numericId, OutputInterface $output) { | |||
| public function deleteFiles($numericId, OutputInterface $output): void { | |||
Check notice
Code scanning / Psalm
MissingParamType Note
fsamapoor
requested review from
a team,
ArtificialOwl,
icewind1991 and
blizzz
and removed request for
a team
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have made some adjustments to the
apps/files_sharing/lib/Commandclasses to improve the code readability.The improvements in this PR include but are not limited to:
Checklist