-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add getDocBaseUrl on theming app #38900
Conversation
@@ -163,6 +164,10 @@ | |||
return (string)$this->config->getAppValue('theming', 'privacyUrl', ''); | |||
} | |||
|
|||
public function getDocBaseUrl() { | |||
return (string)$this->config->getAppValue('theming', 'docBaseUrl', $this->docBaseUrl); |
Check notice
Code scanning / Psalm
RedundantCastGivenDocblockType Note
Signed-off-by: Lorenzo Tanganelli <[email protected]>
ff8197a
to
cc239f5
Compare
fixed psalm |
@icewind1991 @ArtificialOwl @Fenn-CS Any chance to check this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this config would live in config.php
, then it should also be in the config.sample.php
.
Otherwise, I don't know how much we need this so tagging @come-nc
@@ -163,6 +165,10 @@ public function getPrivacyUrl() { | |||
return (string)$this->config->getAppValue('theming', 'privacyUrl', ''); | |||
} | |||
|
|||
public function getDocBaseUrl() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do not understand where is this method used?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@come-nc it's just extending from OC_Defaults
Summary
With new theming introduced on nextcloud >25, we can customize DocBaseUrl only if we use "old fashion way", adding
defaults.php
under/themes/<custom_theme>/
.With this PR I simply added a
getDocBaseUrl()
function, that will get themingdocBaseUrl
config and will use for doc base url.It will fallback on the defaullt one if not found, in the same way as other function.
TODO
N/A
Checklist