Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable25] redis: use atomic operations everywhere #38570

Closed
wants to merge 4 commits into from
Closed

[stable25] redis: use atomic operations everywhere #38570

wants to merge 4 commits into from

Commits on Jun 1, 2023

  1. redis: use atomic operations everywhere 

    This removes a lot of acrobatics in the code and does each operation
atomically using a lua script. This also reduces several round trips
to the server, and the scripts are compiled and cached server-side.

Notably, since all operations work only on a single key (except clear,
which is broken anyway and shouldn't be used), they will continue to
function and be atomic for Redis cluster.

Signed-off-by: Varun Patil <[email protected]>
    @pulsejet @backportbot-nextcloud
    pulsejet authored and backportbot-nextcloud[bot] committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    2d45c82 View commit details
    Browse the repository at this point in the history

  2. add test to verify redis lua script hashes 

    Signed-off-by: Robin Appelman <[email protected]>
    @icewind1991 @backportbot-nextcloud
    icewind1991 authored and backportbot-nextcloud[bot] committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    771d9a9 View commit details
    Browse the repository at this point in the history

  3. redis: move lua scripts to class and add type hints 

    Signed-off-by: Varun Patil <[email protected]>
    @pulsejet @backportbot-nextcloud
    pulsejet authored and backportbot-nextcloud[bot] committed Jun 1, 2023
    Configuration menu
    Copy the full SHA
    cb6aaec View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2023

  1. Fix backport 

    Signed-off-by: Git'Fellow <[email protected]>

Update Redis.php

Signed-off-by: Git'Fellow <[email protected]>

Fix typo

Signed-off-by: Git'Fellow <[email protected]>

Fix self:: calls

Signed-off-by: Git'Fellow <[email protected]>

Fix CI

Signed-off-by: Git'Fellow <[email protected]>
    @solracsf
    solracsf committed Jun 22, 2023
    Configuration menu
    Copy the full SHA
    8a6c2d3 View commit details
    Browse the repository at this point in the history