fix(systemtags): Add missing systemtags index

Signed-off-by: Marcel Klehr <[email protected]>
nextcloud · Jun 21, 2023 · fcf1c30 · fcf1c30
1 parent 32bbe3d
commit fcf1c30
Show file tree

Hide file tree

Showing 3 changed files with 72 additions and 0 deletions.
diff --git a/core/Application.php b/core/Application.php
@@ -243,6 +243,13 @@ function (GenericEvent $event) use ($container) {
 						$subject->addHintForMissingSubject($table->getName(), 'mounts_user_root_path_index');
 					}
 				}
+
+				if ($schema->hasTable('systemtag_object_mapping')) {
+					$table = $schema->getTable('systemtag_object_mapping');
+					if (!$table->hasIndex('systag_by_tagid')) {
+						$subject->addHintForMissingSubject($table->getName(), 'systag_by_tagid');
+					}
+				}
 			}
 		);
 

diff --git a/core/Command/Db/AddMissingIndices.php b/core/Command/Db/AddMissingIndices.php
@@ -472,6 +472,19 @@ private function addCoreIndexes(OutputInterface $output, bool $dryRun): void {
 			}
 		}
 
+		$output->writeln('<info>Check indices of the oc_systemtag_object_mapping table.</info>');
+		if ($schema->hasTable('oc_systemtag_object_mapping')) {
+			$table = $schema->getTable('oc_systemtag_object_mapping');
+			if (!$table->hasIndex('systag_by_tagid')) {
+				$output->writeln('<info>Adding systag_by_tagid index to the oc_systemtag_object_mapping table, this can take some time...</info>');
+
+				$table->addIndex(['systemtagid', 'objecttype'], 'systag_by_tagid');
+				$this->connection->migrateToSchema($schema->getWrappedSchema());
+				$updated = true;
+				$output->writeln('<info>oc_systemtag_object_mapping table updated successfully.</info>');
+			}
+		}
+
 		if (!$updated) {
 			$output->writeln('<info>Done.</info>');
 		}

diff --git a/core/Migrations/Version28000Date20230621185127.php b/core/Migrations/Version28000Date20230621185127.php
@@ -0,0 +1,52 @@
+<?php
+
+declare(strict_types=1);
+
+/**
+ * @copyright Copyright (c) 2023 Marcel Klehr <[email protected]>
+ *
+ * @author Marcel Klehr <[email protected]>
+ *
+ * @license GNU AGPL version 3 or any later version
+ *
+ * This program is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU Affero General Public License as
+ * published by the Free Software Foundation, either version 3 of the
+ * License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU Affero General Public License for more details.
+ *
+ * You should have received a copy of the GNU Affero General Public License
+ * along with this program. If not, see <http://www.gnu.org/licenses/>.
+ *
+ */
+namespace OC\Core\Migrations;
+
+use Closure;
+use OCP\DB\ISchemaWrapper;
+use OCP\Migration\IOutput;
+use OCP\Migration\SimpleMigrationStep;
+
+class Version28000Date20230621185127 extends SimpleMigrationStep {
+	/**
+	 * @param IOutput $output
+	 * @param Closure $schemaClosure The `\Closure` returns a `ISchemaWrapper`
+	 * @param array $options
+	 * @return null|ISchemaWrapper
+	 */
+	public function changeSchema(IOutput $output, Closure $schemaClosure, array $options): ?ISchemaWrapper {
+		/** @var ISchemaWrapper $schema */
+		$schema = $schemaClosure();
+
+		$table = $schema->getTable('systemtag_object_mapping');
+		if (!$table->hasIndex('systag_by_tagid')) {
+			$table->addIndex(['systemtagid', 'objecttype'], 'systag_by_tagid');
+			return $schema;
+		}
+
+		return null;
+	}
+}