Fix response types

Signed-off-by: jld3103 <[email protected]>

apps/settings/lib/WellKnown/ChangePasswordHandler.php

@@ -26,6 +26,7 @@
 namespace OCA\Settings\WellKnown;
 
 use OCP\AppFramework\Http\RedirectResponse;
+use OCP\AppFramework\Http\Response;
 use OCP\Http\WellKnown\GenericResponse;
 use OCP\Http\WellKnown\IHandler;
 use OCP\Http\WellKnown\IRequestContext;
@@ -45,6 +46,7 @@ public function handle(string $service, IRequestContext $context, ?IResponse $pr
 			return $previousResponse;
 		}
 
+		/** @var Response $response */
 		$response = new RedirectResponse($this->urlGenerator->linkToRouteAbsolute('settings.PersonalSettings.index', ['section' => 'security']));
 		return new GenericResponse($response);
 	}

lib/private/AppFramework/Middleware/CompressionMiddleware.php

@@ -7,6 +7,7 @@
  *
  * @author Morris Jobke <[email protected]>
  * @author Roeland Jago Douma <[email protected]>
+ * @author Kate Döen <[email protected]>
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -46,6 +47,9 @@ public function __construct(IRequest $request) {
 		$this->useGZip = false;
 	}
 
+	/**
+	 * @param Response<int, array<string, mixed>> $response
+	 */
 	public function afterController($controller, $methodName, Response $response) {
 		// By default we do not gzip
 		$allowGzip = false;

lib/private/AppFramework/Middleware/OCSMiddleware.php

@@ -6,6 +6,7 @@
  * @author Joas Schilling <[email protected]>
  * @author Lukas Reschke <[email protected]>
  * @author Roeland Jago Douma <[email protected]>
+ * @author Kate Döen <[email protected]>
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -90,7 +91,7 @@ public function afterException($controller, $methodName, \Exception $exception)
 	/**
 	 * @param Controller $controller
 	 * @param string $methodName
-	 * @param Response $response
+	 * @param Response|JSONResponse $response
 	 * @return \OCP\AppFramework\Http\Response
 	 */
 	public function afterController($controller, $methodName, Response $response) {
@@ -102,7 +103,7 @@ public function afterController($controller, $methodName, Response $response) {
 			if ($response->getStatus() === Http::STATUS_UNAUTHORIZED) {
 				$message = '';
 				if ($response instanceof JSONResponse) {
-					/** @var DataResponse $response */
+					/** @var DataResponse<Http::STATUS_UNAUTHORIZED, array, array{}> $response */
 					$message = $response->getData()['message'];
 				}
 
@@ -111,7 +112,7 @@ public function afterController($controller, $methodName, Response $response) {
 			if ($response->getStatus() === Http::STATUS_FORBIDDEN) {
 				$message = '';
 				if ($response instanceof JSONResponse) {
-					/** @var DataResponse $response */
+					/** @var DataResponse<Http::STATUS_FORBIDDEN, array, array{}> $response */
 					$message = $response->getData()['message'];
 				}
 

lib/private/AppFramework/OCS/BaseResponse.php

@@ -7,6 +7,7 @@
  * @author Joas Schilling <[email protected]>
  * @author Lukas Reschke <[email protected]>
  * @author Roeland Jago Douma <[email protected]>
+ * @author Kate Döen <[email protected]>
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -30,6 +31,13 @@
 use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\Http\Response;
 
+/**
+ * @psalm-import-type DataResponseType from DataResponse
+ * @template S of int
+ * @template-covariant T of DataResponseType
+ * @template H of array<string, mixed>
+ * @template-extends Response<S, H>
+ */
 abstract class BaseResponse extends Response {
 	/** @var array */
 	protected $data;
@@ -49,7 +57,7 @@ abstract class BaseResponse extends Response {
 	/**
 	 * BaseResponse constructor.
 	 *
-	 * @param DataResponse $dataResponse
+	 * @param DataResponse<S, T, H> $dataResponse
 	 * @param string $format
 	 * @param string|null $statusMessage
 	 * @param int|null $itemsCount

lib/private/AppFramework/OCS/V1Response.php

@@ -5,6 +5,7 @@
  * @author Christoph Wurst <[email protected]>
  * @author Joas Schilling <[email protected]>
  * @author Roeland Jago Douma <[email protected]>
+ * @author Kate Döen <[email protected]>
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -25,13 +26,22 @@
 namespace OC\AppFramework\OCS;
 
 use OCP\AppFramework\Http;
+use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\OCSController;
 
+/**
+ * @psalm-import-type DataResponseType from DataResponse
+ * @template S of int
+ * @template-covariant T of DataResponseType
+ * @template H of array<string, mixed>
+ * @template-extends BaseResponse<S, DataResponseType, H>
+ */
 class V1Response extends BaseResponse {
 	/**
 	 * The V1 endpoint has very limited http status codes basically everything
 	 * is status 200 except 401
 	 *
+	 * @psalm-suppress ImplementedReturnTypeMismatch Expected because we match some status codes
 	 * @return int
 	 */
 	public function getStatus() {

lib/private/AppFramework/OCS/V2Response.php

@@ -4,6 +4,7 @@
  *
  * @author Christoph Wurst <[email protected]>
  * @author Roeland Jago Douma <[email protected]>
+ * @author Kate Döen <[email protected]>
  *
  * @license GNU AGPL version 3 or any later version
  *
@@ -24,13 +25,22 @@
 namespace OC\AppFramework\OCS;
 
 use OCP\AppFramework\Http;
+use OCP\AppFramework\Http\DataResponse;
 use OCP\AppFramework\OCSController;
 
+/**
+ * @psalm-import-type DataResponseType from DataResponse
+ * @template S of int
+ * @template-covariant T of DataResponseType
+ * @template H of array<string, mixed>
+ * @template-extends BaseResponse<S, DataResponseType, H>
+ */
 class V2Response extends BaseResponse {
 	/**
 	 * The V2 endpoint just passes on status codes.
 	 * Of course we have to map the OCS specific codes to proper HTTP status codes
 	 *
+	 * @psalm-suppress ImplementedReturnTypeMismatch Expected because we match some status codes
 	 * @return int
 	 */
 	public function getStatus() {