Wrap mimetype insert and getLastInsertId in a transaction

Signed-off-by: Lucas Azevedo <[email protected]>
nextcloud · Sep 4, 2023 · c587f68 · c587f68
1 parent 5de021c
commit c587f68
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/lib/private/Files/Type/Loader.php b/lib/private/Files/Type/Loader.php
@@ -117,13 +117,15 @@ public function reset() {
 	 */
 	protected function store($mimetype) {
 		try {
-			$insert = $this->dbConnection->getQueryBuilder();
-			$insert->insert('mimetypes')
-				->values([
-					'mimetype' => $insert->createNamedParameter($mimetype)
-				])
-				->executeStatement();
-			$mimetypeId = $insert->getLastInsertId();
+			$mimetypeId = $this->atomic(function () use ($mimetype) {
+				$insert = $this->dbConnection->getQueryBuilder();
+				$insert->insert('mimetypes')
+					->values([
+						'mimetype' => $insert->createNamedParameter($mimetype)
+					])
+					->executeStatement();
+				return $insert->getLastInsertId();
+			}, $this->dbConnection);
 		} catch (DbalException $e) {
 			if ($e->getReason() !== DBException::REASON_UNIQUE_CONSTRAINT_VIOLATION) {
 				throw $e;