Merge pull request #39537 from nextcloud/ocs-update-group

`/ocs/v1.php/cloud/groups` `UPDATE` method - correct status when group not found
nextcloud · Jul 27, 2023 · b93f101 · b93f101
2 parents 6b72217 + bd19cd6
commit b93f101
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/apps/provisioning_api/lib/Controller/GroupsController.php b/apps/provisioning_api/lib/Controller/GroupsController.php
@@ -271,6 +271,9 @@ public function updateGroup(string $groupId, string $key, string $value): DataRe
 
 		if ($key === 'displayname') {
 			$group = $this->groupManager->get($groupId);
+			if ($group === null) {
+				throw new OCSException('Group does not exist', OCSController::RESPOND_NOT_FOUND);
+			}
 			if ($group->setDisplayName($value)) {
 				return new DataResponse();
 			}