Skip to content

Commit

Permalink
Merge pull request #46524 from nextcloud/backport/45867/stable28
Browse files Browse the repository at this point in the history
  • Loading branch information
skjnldsv authored Jul 28, 2024
2 parents 40e1d35 + 1dc0140 commit 81846da
Show file tree
Hide file tree
Showing 86 changed files with 150 additions and 136 deletions.
37 changes: 25 additions & 12 deletions apps/comments/src/components/Comment.vue
Original file line number Diff line number Diff line change
Expand Up @@ -40,22 +40,27 @@
show if we have a message id and current user is author -->
<NcActions v-if="isOwnComment && id && !loading" class="comment__actions">
<template v-if="!editing">
<NcActionButton :close-after-click="true"
icon="icon-rename"
<NcActionButton close-after-click
@click="onEdit">
<template #icon>
<IconEdit :size="20" />
</template>
{{ t('comments', 'Edit comment') }}
</NcActionButton>
<NcActionSeparator />
<NcActionButton :close-after-click="true"
icon="icon-delete"
<NcActionButton close-after-click
@click="onDeleteWithUndo">
<template #icon>
<IconDelete :size="20" />
</template>
{{ t('comments', 'Delete comment') }}
</NcActionButton>
</template>

<NcActionButton v-else
icon="icon-close"
@click="onEditCancel">
<NcActionButton v-else @click="onEditCancel">
<template #icon>
<IconClose :size="20" />
</template>
{{ t('comments', 'Cancel edit') }}
</NcActionButton>
</NcActions>
Expand Down Expand Up @@ -87,8 +92,8 @@
:disabled="isEmptyMessage"
@click="onSubmit">
<template #icon>
<span v-if="loading" class="icon-loading-small" />
<ArrowRight v-else :size="20" />
<NcLoadingIcon v-if="loading" />
<IconArrowRight v-else :size="20" />
</template>
</NcButton>
</div>
Expand Down Expand Up @@ -122,7 +127,11 @@ import NcActionSeparator from '@nextcloud/vue/dist/Components/NcActionSeparator.
import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar.js'
import NcButton from '@nextcloud/vue/dist/Components/NcButton.js'
import RichEditorMixin from '@nextcloud/vue/dist/Mixins/richEditor.js'
import ArrowRight from 'vue-material-design-icons/ArrowRight.vue'
import IconArrowRight from 'vue-material-design-icons/ArrowRight.vue'
import IconClose from 'vue-material-design-icons/Close.vue'
import IconDelete from 'vue-material-design-icons/Delete.vue'
import IconEdit from 'vue-material-design-icons/Pencil.vue'
import Moment from './Moment.vue'
import CommentMixin from '../mixins/CommentMixin.js'
Expand All @@ -134,15 +143,19 @@ export default {
name: 'Comment',
components: {
IconArrowRight,
IconClose,
IconDelete,
IconEdit,
Moment,
NcActionButton,
NcActions,
NcActionSeparator,
ArrowRight,
NcAvatar,
NcButton,
Moment,
NcRichContenteditable,
},
mixins: [RichEditorMixin, CommentMixin],
inheritAttrs: false,
Expand Down
3 changes: 2 additions & 1 deletion apps/comments/src/views/ActivityCommentEntry.vue
Original file line number Diff line number Diff line change
Expand Up @@ -34,6 +34,7 @@
</template>

<script lang="ts">
import type { PropType } from 'vue'
import { translate as t } from '@nextcloud/l10n'
import Comment from '../components/Comment.vue'
Expand All @@ -53,7 +54,7 @@ export default {
required: true,
},
reloadCallback: {
type: Function,
type: Function as PropType<() => void>,
required: true,
},
},
Expand Down
2 changes: 2 additions & 0 deletions dist/1241-1241.js

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions dist/1241-1241.js.map

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions dist/4065-4065.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/4065-4065.js.map

Large diffs are not rendered by default.

2 changes: 0 additions & 2 deletions dist/5632-5632.js

This file was deleted.

Loading

0 comments on commit 81846da

Please sign in to comment.