Skip to content

Commit

Permalink
show loading icon in 'save share' button when creating a share
Browse files Browse the repository at this point in the history
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: nextcloud-command <[email protected]>
  • Loading branch information
julien-nc authored and nextcloud-command committed Oct 3, 2023
1 parent cc1da88 commit 7bbdd37
Show file tree
Hide file tree
Showing 8 changed files with 15 additions and 7 deletions.
8 changes: 8 additions & 0 deletions apps/files_sharing/src/views/SharingDetailsTab.vue
Original file line number Diff line number Diff line change
Expand Up @@ -197,6 +197,9 @@
</NcButton>
<NcButton type="primary" @click="saveShare">
{{ shareButtonText }}
<template v-if="creating" #icon>
<NcLoadingIcon />
</template>
</NcButton>
</div>
</div>
Expand All @@ -210,6 +213,7 @@ import NcAvatar from '@nextcloud/vue/dist/Components/NcAvatar.js'
import NcDatetimePicker from '@nextcloud/vue/dist/Components/NcDatetimePicker.js'
import NcDateTimePickerNative from '@nextcloud/vue/dist/Components/NcDateTimePickerNative.js'
import NcCheckboxRadioSwitch from '@nextcloud/vue/dist/Components/NcCheckboxRadioSwitch.js'
import NcLoadingIcon from '@nextcloud/vue/dist/Components/NcLoadingIcon.js'
import CircleIcon from 'vue-material-design-icons/CircleOutline.vue'
import CloseIcon from 'vue-material-design-icons/Close.vue'
import EditIcon from 'vue-material-design-icons/Pencil.vue'
Expand Down Expand Up @@ -244,6 +248,7 @@ export default {
NcDatetimePicker,
NcDateTimePickerNative,
NcCheckboxRadioSwitch,
NcLoadingIcon,
CloseIcon,
CircleIcon,
EditIcon,
Expand Down Expand Up @@ -282,6 +287,7 @@ export default {
bundledPermissions: BUNDLED_PERMISSIONS,
isFirstComponentLoad: true,
test: false,
creating: false,
}
},
Expand Down Expand Up @@ -804,7 +810,9 @@ export default {
incomingShare.password = this.share.password
}
this.creating = true
const share = await this.addShare(incomingShare, this.fileInfo)
this.creating = false
this.share = share
this.$emit('add:share', this.share)
} else {
Expand Down
3 changes: 3 additions & 0 deletions dist/10-10.js

Large diffs are not rendered by default.

File renamed without changes.
1 change: 1 addition & 0 deletions dist/10-10.js.map

Large diffs are not rendered by default.

3 changes: 0 additions & 3 deletions dist/520-520.js

This file was deleted.

1 change: 0 additions & 1 deletion dist/520-520.js.map

This file was deleted.

4 changes: 2 additions & 2 deletions dist/files_sharing-files_sharing_tab.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/files_sharing-files_sharing_tab.js.map

Large diffs are not rendered by default.

0 comments on commit 7bbdd37

Please sign in to comment.