Merge pull request #39806 from nextcloud/fix/update-check-no-internet

fix(updatenotification): Skip update check
nextcloud · Aug 11, 2023 · 6cdad2d · 6cdad2d
2 parents 03f5bb6 + de4bc44
commit 6cdad2d
Show file tree

Hide file tree

Showing 2 changed files with 32 additions and 2 deletions.
diff --git a/apps/updatenotification/lib/Notification/BackgroundJob.php b/apps/updatenotification/lib/Notification/BackgroundJob.php
@@ -57,6 +57,11 @@ public function __construct(
 	}
 
 	protected function run($argument) {
+		// Do not check for updates if not connected to the internet
+		if (!$this->config->getSystemValueBool('has_internet_connection', true)) {
+			return;
+		}
+
 		if (\OC::$CLI && !$this->config->getSystemValueBool('debug', false)) {
 			try {
 				// Jitter the pinging of the updater server and the appstore a bit.

diff --git a/apps/updatenotification/tests/Notification/BackgroundJobTest.php b/apps/updatenotification/tests/Notification/BackgroundJobTest.php
@@ -112,9 +112,34 @@ public function testRun() {
 		$job->expects($this->once())
 			->method('checkAppUpdates');
 
+		$this->config->expects($this->exactly(2))
+			->method('getSystemValueBool')
+			->withConsecutive(
+				['has_internet_connection', true],
+				['debug', false],
+			)
+			->willReturnOnConsecutiveCalls(
+				true,
+				true,
+			);
+
+		self::invokePrivate($job, 'run', [null]);
+	}
+
+	public function testRunNoInternet() {
+		$job = $this->getJob([
+			'checkCoreUpdate',
+			'checkAppUpdates',
+		]);
+
+		$job->expects($this->never())
+			->method('checkCoreUpdate');
+		$job->expects($this->never())
+			->method('checkAppUpdates');
+
 		$this->config->method('getSystemValueBool')
-			->with('debug', false)
-			->willReturn(true);
+			->with('has_internet_connection', true)
+			->willReturn(false);
 
 		self::invokePrivate($job, 'run', [null]);
 	}