Merge pull request #46773 from nextcloud/fix/noid/settings-iframe-icons

style(settings): align icons at legacy help navigation
nextcloud · Jul 26, 2024 · 602ef72 · 602ef72
2 parents a618f64 + 0dc4ed1
commit 602ef72
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 5 deletions.
diff --git a/apps/settings/css/help.css b/apps/settings/css/help.css
@@ -7,8 +7,16 @@
 	overflow: hidden !important;
 }
 
+.help-list__link {
+	display: flex;
+	align-items: center;
+	height: var(--default-clickable-area);
+	margin: 0 8px;
+	background-position: left center;
+}
+
 .help-list__text {
-	margin-left: 24px;
+	margin-left: 20px;
 }
 
 .help-iframe {

diff --git a/apps/settings/templates/help.php b/apps/settings/templates/help.php
@@ -9,7 +9,7 @@
 	<div id="app-navigation" role="navigation" tabindex="0">
 		<ul>
 			<li>
-				<a class="icon-user <?php if ($_['mode'] === 'user') {
+				<a class="help-list__link icon-user <?php if ($_['mode'] === 'user') {
 					p('active');
 				} ?>" <?php if ($_['mode'] === 'user') {
 					print_unescaped('aria-current="page"');
@@ -22,7 +22,7 @@
 			</li>
 		<?php if ($_['admin']) { ?>
 			<li>
-				<a class="icon-user-admin <?php if ($_['mode'] === 'admin') {
+				<a class="help-list__link icon-user-admin <?php if ($_['mode'] === 'admin') {
 					p('active');
 				} ?>" <?php if ($_['mode'] === 'admin') {
 					print_unescaped('aria-current="page"');
@@ -36,14 +36,14 @@
 		<?php } ?>
 
 			<li>
-				<a href="https://docs.nextcloud.com" class="icon-category-office" target="_blank" rel="noreferrer noopener">
+				<a href="https://docs.nextcloud.com" class="help-list__link icon-category-office" target="_blank" rel="noreferrer noopener">
 					<span class="help-list__text">
 						<?php p($l->t('Documentation')); ?> ↗
 					</span>
 				</a>
 			</li>
 			<li>
-				<a href="https://help.nextcloud.com" class="icon-comment" target="_blank" rel="noreferrer noopener">
+				<a href="https://help.nextcloud.com" class="help-list__link icon-comment" target="_blank" rel="noreferrer noopener">
 					<span class="help-list__text">
 						<?php p($l->t('Forum')); ?> ↗
 					</span>