[stable29] fix: guest username not picked up the second time loading a share link

cypress/support/commands.js

@@ -142,7 +142,7 @@ Cypress.Commands.add('shareLink', (user, path, shareData = {}) => {
 })
 
 Cypress.Commands.add('openFile', fileName => {
-	cy.get(`[data-cy-files-list] tr[data-cy-files-list-row-name="${fileName}"] a[data-cy-files-list-row-name-link]`).click()
+	cy.get(`[data-cy-files-list-tbody] tr[data-cy-files-list-row-name="${fileName}"] button[data-cy-files-list-row-name-link]`).click()
 })
 
 Cypress.Commands.add('nextcloudEnableApp', (appId) => {

package.json

@@ -24,7 +24,7 @@
     "test:coverage": "NODE_ENV=test jest --coverage"
   },
   "dependencies": {
-    "@nextcloud/auth": "^2.2.1",
+    "@nextcloud/auth": "^2.4.0",
     "@nextcloud/axios": "^2.4.0",
     "@nextcloud/capabilities": "^1.1.0",
     "@nextcloud/dialogs": "^5.2.0",

src/components/GuestNamePicker.vue

@@ -39,10 +39,10 @@
 </template>
 
 <script>
+import { setGuestNickname } from '@nextcloud/auth'
 import { NcButton, NcIconSvgWrapper, NcModal, NcTextField } from '@nextcloud/vue'
 import { translate as t } from '@nextcloud/l10n'
 import axios from '@nextcloud/axios'
-import { setGuestNameCookie } from '../helpers/guestName.js'
 
 export default {
 	name: 'GuestNamePicker',
@@ -103,10 +103,10 @@ export default {
 			this.guestName = guestName
 		},
 		async submit() {
-			setGuestNameCookie(this.guestName)
+			setGuestNickname(this.guestName)
 			this.show = false
 
-			await this.onSubmit(this.guestName)
+			await this.onSubmit()
 		},
 	},
 }

src/helpers/guestName.js

@@ -20,32 +20,23 @@
  *
  */
 
-import { getCurrentUser } from '@nextcloud/auth'
+import {
+	getCurrentUser,
+	getGuestNickname,
+} from '@nextcloud/auth'
 import getLoggedInUser from '../helpers/getLoggedInUser.js'
 
-const cookieAlreadySet = (cookieName) => {
-	return document.cookie
-		.split(';')
-		.some(cookie => {
-			return cookie.trim().startsWith(`${cookieName}=`)
-		})
-}
-
-const setGuestNameCookie = (username) => {
-	if (username !== '') {
-		document.cookie = 'guestUser=' + encodeURIComponent(username) + '; path=/'
-	}
-}
-
-const shouldAskForGuestName = () => {
+/**
+ * Determines if the user should be asked to enter a guest name
+ *
+ * @param {string} mimetype - Mimetype of the file
+ * @param {boolean} canWrite - If write access is granted
+ */
+export function shouldAskForGuestName(mimetype, canWrite) {
 	const noLoggedInUser = !getLoggedInUser()
-	const noGuestCookie = !cookieAlreadySet('guestUser')
+	const noGuest = !getGuestNickname()
 	const noCurrentUser = !getCurrentUser() || getCurrentUser()?.uid === ''
+	const isReadOnlyPDF = mimetype === 'application/pdf' && !canWrite
 
-	return noLoggedInUser && noGuestCookie && noCurrentUser
-}
-
-export {
-	setGuestNameCookie,
-	shouldAskForGuestName,
+	return noLoggedInUser && noGuest && noCurrentUser && !isReadOnlyPDF
 }

src/view/Office.vue

@@ -132,7 +132,7 @@ import pickLink from '../mixins/pickLink.js'
 import saveAs from '../mixins/saveAs.js'
 import uiMention from '../mixins/uiMention.js'
 import version from '../mixins/version.js'
-import { getCurrentUser } from '@nextcloud/auth'
+import { getCurrentUser, getGuestNickname } from '@nextcloud/auth'
 import { shouldAskForGuestName } from '../helpers/guestName.js'
 
 const FRAME_DOCUMENT = 'FRAME_DOCUMENT'
@@ -191,8 +191,6 @@ export default {
 			errorType: null,
 			loadingMsg: null,
 
-			guestName: null,
-
 			showLinkPicker: false,
 			showZotero: false,
 			modified: false,
@@ -293,8 +291,7 @@ export default {
 
 			spawnDialog(GuestNamePicker, {
 				fileName: basename(this.filename),
-				onSubmit: async (guestName) => {
-					this.guestName = guestName
+				onSubmit: async () => {
 					await this.load()
 				},
 			})
@@ -314,7 +311,7 @@ export default {
 
 			// Generate WOPI token
 			const { data } = await axios.post(generateUrl('/apps/richdocuments/token'), {
-				fileId: fileid, shareToken: this.shareToken, version, guestName: this.guestName,
+				fileId: fileid, shareToken: this.shareToken, version, guestName: getGuestNickname(),
 			})
 			Config.update('urlsrc', data.urlSrc)
 			Config.update('wopi_callback_url', loadState('richdocuments', 'wopi_callback_url', ''))