Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: PDF Template Workflow #3798

Merged
merged 31 commits into from
Jul 25, 2024
Merged

feat: PDF Template Workflow #3798

merged 31 commits into from
Jul 25, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Jun 24, 2024 •
edited
Loading

Summary

API which handles the extraction and filling of form controls in template documents. This means that a user will be able to input form controls in the document via Collabora Online, and when creating a new document based on that template, have the option to fill out the fields and they will be populated when the document is created. This is required for the workflow and automation improvements.

Related server pull request: nextcloud/server#46383

TODO

  • Also accept any document, not just templates -- user may want to get/fill fields from other documents as well
  • Testing, would need help with this, was not working locally when I tried :)

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody elzody self-assigned this Jun 24, 2024
@elzody elzody added enhancement New feature or request 2. developing Work in progress php Pull requests that update Php code feature: templates labels Jun 24, 2024
@elzody elzody added this to the Nextcloud 30 milestone Jun 24, 2024
@elzody elzody force-pushed the feat/pdf-template-workflow branch from 5e80454 to 95c9945 Compare June 24, 2024 17:51
@elzody elzody requested a review from juliushaertl June 24, 2024 18:16
@juliushaertl

This comment was marked as resolved.

Sign in to view
@elzody elzody force-pushed the feat/pdf-template-workflow branch from a0ca8b0 to 25a479a Compare July 9, 2024 19:52
@elzody elzody marked this pull request as ready for review July 25, 2024 12:36
@elzody elzody requested a review from blizzz July 25, 2024 12:36
juliushaertl
juliushaertl reviewed Jul 25, 2024
View reviewed changes
tests/stub.phpstub Outdated Show resolved Hide resolved
elzody added 11 commits July 25, 2024 09:08
@elzody
feat: Add Controller, Service files
ead5d1b 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
refactor: Rename controller
ea936f9 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
testing
e8d18af 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Add fileId param to route path
23981a3 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
Basic controller and service
919e316 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Add attributes
0920c41 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Use required attributes/classes
c8d564f 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Composer dump
8d82a68 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Add SPDX headers
c8b4549 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Hit Collabora endpoint from service
6323ae5 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: fillFields method
1974607 
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody and others added 19 commits July 25, 2024 09:08
@elzody
fix: Remove use of type Node
bc59697 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Add field classes to template field service
4fb597e 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Inject template fields via new BeforeGetTemplates events
965c665 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: SPDX header for BeforeGetTemplatesListener
b5cfc69 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Template field classes
f425774 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: TemplateFieldService can use either Node or file ID
1014bdb 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Add index and content to Field type
924c25f 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: move Field and FieldType back to server API
a30356c 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Extract fields from Collabora response
3e217c7 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Hit Collabora endpoint to extract fields
16a6605 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Get Node if given an ID
68f70c8 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Add alias to field
6c39bd5 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
feat: Add API for filling templates
fda372f 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@juliushaertl @elzody
fix: Map field type to enum
5a4ec78 
Signed-off-by: Julius Härtl <[email protected]>
@elzody
fix: Update nextcloud/ocp to fix psalm errors
9e881ad 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Use constructor promotion to reduce boilerplate
8f112c3 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Remove unneeded class from phpstub
3fd504c 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Use default options in requests
f63d502 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody
fix: Log and handle errors
6f85ff4 
Signed-off-by: Elizabeth Danzberger <[email protected]>
@elzody elzody force-pushed the feat/pdf-template-workflow branch from ac56967 to 6f85ff4 Compare July 25, 2024 13:50
juliushaertl
juliushaertl approved these changes Jul 25, 2024
View reviewed changes
Copy link
Member

@juliushaertl juliushaertl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one small thing left, otherwise 👍

lib/Controller/TemplateFieldController.php Outdated Show resolved Hide resolved
@elzody elzody enabled auto-merge July 25, 2024 15:51
@elzody elzody merged commit 09f4c56 into main Jul 25, 2024
59 checks passed
@elzody elzody deleted the feat/pdf-template-workflow branch July 25, 2024 16:10
@juliushaertl juliushaertl mentioned this pull request Aug 2, 2024
Merged
@juliushaertl juliushaertl mentioned this pull request Aug 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@blizzz blizzz Awaiting requested review from blizzz

Assignees

@elzody elzody

Labels
2. developing Work in progress enhancement New feature or request feature: templates php Pull requests that update Php code
Projects
None yet
Milestone
Nextcloud 30
Development

Successfully merging this pull request may close these issues.

Template-based PDF generation via API
2 participants
@elzody @juliushaertl