Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redesign guest name picker and fix opening it for shared folders #3606

Merged
merged 1 commit into from
Apr 30, 2024
Merged

Redesign guest name picker and fix opening it for shared folders #3606

merged 1 commit into from
Apr 30, 2024

Conversation

elzody
Copy link
Contributor

@elzody elzody commented Apr 19, 2024 •
edited
Loading

📝 Summary

This pull request uses Office.vue to ask for guest username, which solves the problem of a guest not being asked for a username when accessing a public share located within a shared folder (instead of a direct share link to a file).

🖼️ Screenshots

Guest username modal

image

☑️ Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Documentation (manuals or wiki) has been updated or is not required

@elzody elzody added bug Something isn't working enhancement New feature or request 2. developing Work in progress labels Apr 19, 2024
@elzody elzody self-assigned this Apr 19, 2024
@elzody elzody linked an issue Apr 19, 2024 that may be closed by this pull request
Accessing a document from a public shared folder does not ask for guest username #3557
Closed
@elzody elzody force-pushed the fix/guest-username branch 3 times, most recently from b16f9c5 to b44cb56 Compare April 24, 2024 20:25
szaimen
szaimen approved these changes Apr 25, 2024
View reviewed changes
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot looks good from design perspective :)

@elzody elzody marked this pull request as ready for review April 26, 2024 19:57
@juliushaertl juliushaertl changed the title Fix/guest username Redesign guest name picker and fix opening it for shared folders Apr 30, 2024
@juliushaertl
Copy link
Member

Rebased on top of #3634

@juliushaertl
Copy link
Member

Seems I broke it when rebasing, but should be a quick fix now

@juliushaertl juliushaertl changed the base branch from main to tests/cypress-24.04 April 30, 2024 13:35
@delete-merged-branch delete-merged-branch bot deleted the branch main April 30, 2024 14:54
@elzody elzody changed the base branch from tests/cypress-24.04 to main April 30, 2024 16:38
@elzody
fix: guest name picker
63aece8 
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Julius Härtl <[email protected]>
@elzody elzody enabled auto-merge April 30, 2024 17:11
@elzody elzody disabled auto-merge April 30, 2024 17:11
@elzody
Copy link
Contributor Author

elzody commented Apr 30, 2024

/backport to stable29

@elzody
Copy link
Contributor Author

elzody commented Apr 30, 2024

/backport to stable28

@elzody
Copy link
Contributor Author

elzody commented Apr 30, 2024

/backport to stable27

@elzody elzody merged commit 2383f3a into main Apr 30, 2024
55 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/guest-username branch April 30, 2024 17:24
This was referenced Apr 30, 2024
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliushaertl juliushaertl juliushaertl approved these changes

@szaimen szaimen szaimen approved these changes

Assignees

@elzody elzody

Labels
2. developing Work in progress bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Accessing a document from a public shared folder does not ask for guest username Redesign guest name input
3 participants
@elzody @juliushaertl @szaimen