refactor: move to office.vue component #3600
Conversation
elzody
added
enhancement
|
The failure of direct.spec.js is expected as the full document.js was removed. This and federated editing are two other leftover cases where it is in use which are probably a bit more tricky to migrate. Let's maybe chat tomorrow about those, i need to think a bit about how we can move those over as well |
elzody
force-pushed
the
refactor-to-office-vue
branch
2 times, most recently
from
18d3ec7
to
408ca33
Compare
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
Signed-off-by: Elizabeth Danzberger <[email protected]>
elzody
force-pushed
the
refactor-to-office-vue
branch
from
f4a8381
to
2250420
Compare
Signed-off-by: Julius Härtl <[email protected]>
|
@elzody I pushed a small revert for We use an environment variable to pass in the collabora url for CI and therefore it was failing with just using the cypress config option: Then the failure of the settings test also caused a failure on the other one as the collabora url has no longer been properly set For adjusting URLs on local runs I usually just use: |
| cy.get('@postMessage', { timeout: 20000 }).should(spy => { | ||
| const calls = spy.getCalls() | ||
| const findMatchingCall = calls.find(call => call.args[0].indexOf('"MessageId":"App_LoadingStatus"') !== -1) | ||
| if (!findMatchingCall) { | ||
| return expect(findMatchingCall).to.not.be.undefined | ||
| } | ||
| const object = JSON.parse(findMatchingCall.args[0]) | ||
| expect(object.Values).to.have.property('Status', 'Initialized') | ||
| }) |
There was a problem hiding this comment.
We might want to move this into a cypress command that can be reused in the future. So we can assert post messages in other tests as wel. For now fine to just keep it as it is i think.
|
/backport to stable29 |
|
/backport to stable28 |
|
/backport to stable27 |
Summary
Removes
document.jswhich contains legacy code and is difficult to maintain, replacing it with theOffice.vuecomponent.This will help complete #3557
Checklist