don't alter file when there is not enough free space #3562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
juliushaertl
reviewed
Apr 4, 2024
juliushaertl
reviewed
Apr 4, 2024
juliushaertl
reviewed
Apr 4, 2024
juliushaertl
reviewed
Apr 4, 2024
grnd-alt
force-pushed
the
fix/3281-file-gets-truncated-on-save-when-quota-is-exceeded
branch
from
cd6535b
to
cf33ed4
Compare
grnd-alt
force-pushed
the
fix/3281-file-gets-truncated-on-save-when-quota-is-exceeded
branch
2 times, most recently
from
97d2459
to
b1ef0b3
Compare
juliushaertl
requested changes
Apr 10, 2024
juliushaertl
approved these changes
Apr 11, 2024
|
Can you squash the commit to have a clean history? |
Signed-off-by: grnd-alt <[email protected]>
grnd-alt
force-pushed
the
fix/3281-file-gets-truncated-on-save-when-quota-is-exceeded
branch
from
b9dc420
to
b72d576
Compare
delete-merged-branch
bot
deleted the
fix/3281-file-gets-truncated-on-save-when-quota-is-exceeded
branch
|
/backport to stable27 |
|
/backport to stable28 |
|
/backport to stable29 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When Updating files via WOPI the file used to be written from the beginning just to realize mid writing that there's not enough space and throw an error. Therefore the entire doc gets broken and mostly unusable.
Now: When a File is to be updated it gets checked if it would exceed the free space on storage/quota, if not an error is thrown and the file is left as is.