fix: suggested improvements

Signed-off-by: Elizabeth Danzberger <[email protected]>
nextcloud · Aug 19, 2024 · beee109 · beee109
1 parent 6036628
commit beee109
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/lib/Service/TemplateFieldService.php b/lib/Service/TemplateFieldService.php
@@ -29,7 +29,6 @@ public function __construct(
 		private LoggerInterface $logger,
 		private ICacheFactory $cacheFactory
 	) {
-		$this->cache = $cacheFactory->createLocal('richdocuments_templates/');
 	}
 
 	/**
@@ -50,10 +49,11 @@ public function extractFields(Node|int $file) {
 				throw new NotFoundException();
 			}
 
+			$localCache = $this->cacheFactory->createLocal('richdocuments_templates/');
 			$cacheName = $file->getId() . "/" . $file->getEtag();
-			$cachedResponse = $this->cache->get($cacheName);
+			$cachedResponse = $localCache->get($cacheName);
 
-			if ($cachedResponse) {
+			if ($cachedResponse !== null) {
 				return $cachedResponse;
 			}
 
@@ -95,7 +95,7 @@ public function extractFields(Node|int $file) {
 			}
 
 			$fields = array_merge([], ...$fields);
-			$this->cache->set($cacheName, $fields, 3600);
+			$localCache->set($cacheName, $fields, 3600);
 
 			return $fields;
 		} catch (\Exception $e) {