fix(sharing): Don't ask for guest name on view-only share

Signed-off-by: Elizabeth Danzberger <[email protected]>

cypress/e2e/share-link.js

@@ -58,7 +58,9 @@ describe('Public sharing of office documents', function() {
 					},
 				})
 
-				cy.inputCollaboraGuestName(guestName)
+				// Assert that we do not ask for guest name on readonly document
+				cy.get('[data-cy="guestNameModal"]').should('not.exist')
+
 				cy.waitForCollabora()
 				cy.waitForPostMessage('App_LoadingStatus', { Status: 'Document_Loaded' })
 

src/helpers/guestName.js

@@ -21,5 +21,9 @@ export function shouldAskForGuestName(mimetype, canWrite) {
 	const noCurrentUser = !getCurrentUser() || getCurrentUser()?.uid === ''
 	const isReadOnlyPDF = mimetype === 'application/pdf' && !canWrite
 
+	if (!canWrite) {
+		return false
+	}
+
 	return noLoggedInUser && noGuest && noCurrentUser && !isReadOnlyPDF
 }