Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend is outdated #195

Closed
BernhardPosselt opened this issue Jun 15, 2017 · 32 comments · Fixed by #748
Closed

Frontend is outdated #195

BernhardPosselt opened this issue Jun 15, 2017 · 32 comments · Fixed by #748
Assignees
Labels
Milestone

Comments

@BernhardPosselt
Copy link
Member

BernhardPosselt commented Jun 15, 2017

The frontend is outdated in various ways and is therefore way harder to maintain then needed:

  • Building the js bundle should be done with a few lines of webpack
  • After webpack is set up we can move to modularizing the code and use es6 module loading
  • Minification should be done with babili since uglifyjs doesnt work with anything remotely ES6 nor newer
  • Thirdparty libs should be pulled in entire from npm
  • Frontend should probably be migrated to a newer Angular or different technology

For an example webpack file with typescript see https://github.com/nextcloud/appstore/blob/master/webpack.config.js and https://github.com/nextcloud/appstore/blob/master/karma.conf.js for integration with karma


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

@schaal
Copy link
Contributor

schaal commented Jun 16, 2017

Thirdparty libs should be pulled in entire from npm

Was actually already working on that. Just opened #197 to move all dependencies to npm and remove bower.

@danopz danopz mentioned this issue Aug 26, 2017
5 tasks
@georgehrke
Copy link
Member

In the calendar we are currently considering migrating to Vue.js

@stale
Copy link

stale bot commented Jul 31, 2018

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the stale label Jul 31, 2018
@SMillerDev
Copy link
Contributor

@georgehrke did anything ever come of that?

@danopz
Copy link
Contributor

danopz commented Aug 1, 2018

Some apps are already migrated to Vue. On my personal todo list I have a task trying to rewrite the frontend with Vue.js, but don't know when I'm able to start.
In general I would like to see a new maintainable frontend. 😀

@georgehrke
Copy link
Member

@SMillerDev Not yet, but @skjnldsv is already working on migrating the Contacts app to Vue.js.
We will do the same for the Calendar app once we successfully moved the Contacts app.

@skjnldsv
Copy link
Member

skjnldsv commented Aug 1, 2018

@danopz We already have a lot of components ready-to-use for vue. If you want to upgrade the news app, we'll help you with a great joy ;)

@JonathanTreffler
Copy link

I would be glad to help migrating this app to vue.js.

I migrated the flowupload app to vue (from angular) a month ago (the frontend of this app is obviously more complicated)

@jancborchardt
Copy link
Member

jancborchardt commented Jul 31, 2020

@Grotax @JonathanTreffler @schaal @SMillerDev @danopz @BernhardPosselt we have a Nextcloud Talk instance also with e.g. a channel for Vue discussions, as well as a "News team" channel – it’s not very active yet but we do have @David-Development @stefan-niedermann and @phedlund already in! :)

I can add you there with your email address and name if you like, then you can disuss about updating it to the Vue components?

@jancborchardt
Copy link
Member

And another thing: We are working on a new "Dashboard" at the moment and it would be quite cool if there would be a News app widget for it? 🙂 – see details at nextcloud/server#20930

@SMillerDev
Copy link
Contributor

Pull requests are welcome 🤷‍♂️

@JonathanTreffler
Copy link

I can add you there with your email address and name if you like, then you can disuss about updating it to the Vue components?

My email adress is [email protected] 😀

@jancborchardt
Copy link
Member

@SMillerDev @Grotax (and others) should I also add you? :)

@SMillerDev
Copy link
Contributor

@SMillerDev @Grotax (and others) should I also add you? :)

I'm not really gonna spend any time on the vue migration, but if you want you can invite me with <username>@me.com

@Grotax
Copy link
Member

Grotax commented Aug 4, 2020

Yea sure but I'm not very active at the moment [email protected]

@JonathanTreffler
Copy link

I can add you there with your email address and name if you like, then you can disuss about updating it to the Vue components?

How can we get access ? Is it the instance at cloud.nextcloud.com ?

@jancborchardt
Copy link
Member

Just invited the 3 of you, you should get an invitation mail. :) Yes it is the instance at cloud.nextcloud.com – and you will also be able to e.g. use the mobile apps for convenience. (You can change your names and also set avatars, but file upload is restricted for guest users.)

@JonathanTreffler
Copy link

JonathanTreffler commented Aug 7, 2020

(i changed my github username to JonathanTreffler and updated comments mentioning my old username. I wanted to change it for a while and the number of mentions i then need to update only increases)

@Grotax Grotax unpinned this issue Oct 14, 2020
@SMillerDev SMillerDev added the frontend impact Javascript/Frontend code label Dec 11, 2020
@Grotax Grotax pinned this issue Sep 21, 2021
@Grotax
Copy link
Member

Grotax commented Sep 21, 2021

The Angular version of news will only be supported until end of 2021.

@rakekniven rakekniven unpinned this issue Nov 8, 2021
@Grotax Grotax pinned this issue Dec 3, 2021
@CarlSchwan
Copy link
Member

I updated the admin page to vue here #1880 , would be great if someone could give it a review

@meichthys
Copy link

It looks like the frontend is updated to vue as well in v18.2.0

@SMillerDev
Copy link
Contributor

The admin settings are but nothing else is.

@powerpaul17
Copy link
Contributor

Sorry if I post this here on the wrong place but I was thinking about contributing to the vue rewrite but it's getting a bit messy here with all the branches and PRs. Which one is the most promising/recent one? And can we coordinate work on that?

@Grotax
Copy link
Member

Grotax commented Oct 21, 2022

@CarlSchwan migrated the admin settings to Vue js already that part is done.
He also took the existing work and cleaned the code a bit, but didn't continue after that probably due to time constraints. You can find a PR with the changes.

@devlinjunker continued the work on the vue-rewrite branch, there are already some commits on that branch, you can find pull requests in his forked repository that are in progress.

That is the latest status.

@rhyst
Copy link
Contributor

rhyst commented Oct 24, 2022

Are the forks by @CarlSchwan and @devlinjunker different? Is it clear at the moment which to contribute to?

@Grotax
Copy link
Member

Grotax commented Oct 25, 2022

I can't really say. Both are quite in the beginning.

Probably best of you take a look at both and decide for yourself which is the better base to contribute to.

@Grotax
Copy link
Member

Grotax commented Nov 2, 2022

Latest changes were done here: #1968

@mhzawadi
Copy link

Good evening 👋🏼

I see this has been ongoing for some time, I also see that some of the issues affected by this are still ongoing.

Is there any update on when a rewrite of the frontend will complete?
An issue that was opened about date order was closed as the fix is a rewrite, but thats still in progress.

@SMillerDev
Copy link
Contributor

It'll be done when it is done. You can't plan volunteer time and motivation.

@scottdotau
Copy link

Hi.

I have been looking into this for personal use, and am open to volunteering on this myself.

Feel free to shoot me an email (excuse the alias address, will reply on regular ☺) : [email protected]

Have the opportunity to spend quite a bit of time volunteering for a good chunk of time - happy to send though experience, etc - however have experience in most tech mentioned above (php, js, vue). Full stack, but better in front end ☺.

@SMillerDev
Copy link
Contributor

@scottdotau there is #748 that has regular contributions. Those contributions have a TODO, so you could pick something up from that.

@scottdotau
Copy link

@SMillerDev appreciate it, obviously didn't read all the replies 🙃.

@Grotax Grotax unpinned this issue Oct 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.