-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(neon_framework): Enable viewing and editing profile properties #2345
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2345 +/- ##
==========================================
+ Coverage 26.32% 26.41% +0.09%
==========================================
Files 362 365 +3
Lines 136541 136701 +160
==========================================
+ Hits 35940 36112 +172
+ Misses 100601 100589 -12
*This pull request uses carry forward flags. Click here to find out more.
|
ad33020
to
cb4e86d
Compare
cb4e86d
to
2789fd8
Compare
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
Signed-off-by: provokateurin <[email protected]>
2789fd8
to
4c877ac
Compare
With the account repository merged and used everywhere, can we now take a look at this PR @Leptopoda? |
I don't think repositories should have any callbacks. My Idea for this would be:
Instead of the |
Closes #2326
Closes #2327
Currently the password confirmation is triggered on the UI side and not the bloc side which I do not like, but the alternative would be to register a global callback that would be called in the blocs. I'm not a fan of that either, so I wonder if you have a better way to implement this.
The main point of the PR is to implement the password confirmation, editing the profile is only secondary and used as an example. If the later needs more work I'd be pleased to already merge the password confirmation in case the discussions around that are already resolved.