-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restyle envelope view #9928
Restyle envelope view #9928
Conversation
Right so now I have moved all the new styling to the
The only bad thing is in order for the avatar icon to be the same size as the first two lines (as per @marcoambrosini's request), I needed to use some deep selectors at the end, due to the size being set by server styling. EDIT just noticed some styling is messed up when selected, fixing now EDIT 2: made all text become white when selected and actions behave properly when selected |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing @GVodyanov, I would just move the date to the top in line with the title, could you please post screenshots of action menu on hover and of selected item? Thanks :)
There you go, here is the date aligned up top now: I also just noticed that the top padding is a bit larger than the side padding, now I made it |
…ponent in Mail and use it in Envelope Signed-off-by: Grigory V <[email protected]> feat(EnvelopeSkeleton): create a new envelope structure component in Mail Signed-off-by: Grigory Vodyanov <[email protected]>
6f7cb7c
to
31aff9f
Compare
@ChristophWurst I understand this is pretty urgent, and I'm going on vacation next week. If you approve, I reckon you should merge this without waiting for me, so I just rebased everything after implementing Marco's review to make it as easy as possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works very well 👏
Very nice! there still is some misalignment though: both the date and the actions need to be aligned to the top of the component, with the first line of text |
See nextcloud-libraries/nextcloud-vue#5871, this is just adjusting mail for the real party down at Nextcloud vue