chore: rename sieve security to sieve filter #10100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
kesselb
commented
Sep 4, 2024
•
kesselb
commented
- Rename "Enable sieve security" to "Enable sieve filter"
- Use the translation function
- Add a small introduction for the feature
|
/backport to stable4.0 |
src/components/SieveAccountForm.vue
Outdated
| @@ -4,9 +4,12 @@ | |||
| --> | |||
| <template> | |||
| <form id="sieve-form"> | |||
| <p> | |||
| {{ t('mail', 'Sieve is a powerful language for writing filters for your mailbox. You can control the sieve scripts from Nextcloud Mail if your email service supports it.')}} | |||
There was a problem hiding this comment.
Suggested change
| {{ t('mail', 'Sieve is a powerful language for writing filters for your mailbox. You can control the sieve scripts from Nextcloud Mail if your email service supports it.')}} | |
| {{ t('mail', 'Sieve is a powerful language for writing filters for your mailbox. You can control the sieve scripts from {product} Mail if your email service supports it.', { product: OCA.theme.????? })}} |
we use it in other places too. forgot the exact variable ;-)
There was a problem hiding this comment.
mail/src/components/NoMessageSelected.vue
Line 33 in 629a9fa
There was a problem hiding this comment.
I like the idea 👍
f17aba4 did not work, even if window?.OC?.theme?.name evaluates to "Testcloud". I assume that OC.theme is not populated when the component is rendered, but didn't look at it properly.
Pushed another fixup to use a wording without Nextcloud. Let me know if you want me to take a look later to include the instance name or product name, I will create an issue then.
There was a problem hiding this comment.
Then let's avoid the name 👍
ChristophWurst
approved these changes
Sep 4, 2024
- Rename "Enable sieve security" to "Enable sieve filter" - Use the translation function - Add a small introduction for the feature Signed-off-by: Daniel Kesselberg <[email protected]>
kesselb
force-pushed
the
bug/noid/sieve-security
branch
from
00c4588
to
43da1d8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.