feat: unit tests for link checking #10075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kesselb
reviewed
Aug 30, 2024
|
Merge this one into the other branch? ;) The tests are failing, because the fix is not in, yet. |
I can rebase and merge to main later. since they're unrelated PRs |
kesselb
reviewed
Sep 2, 2024
There was a problem hiding this comment.
Whitespaces in test are a bit random
One way to structure them is the A-A-A pattern
- Arrange block
- Blank line
- Act block
- Blank line
- Assert block
This would fit nicely for the tests here.
https://automationpanda.com/2020/07/07/arrange-act-assert-a-pattern-for-writing-good-tests/
hamza221
force-pushed
the
enh/unit-tests-link-checking
branch
from
9e8afef
to
146b2f5
Compare
Signed-off-by: Hamza Mahjoubi <[email protected]>
hamza221
force-pushed
the
enh/unit-tests-link-checking
branch
from
146b2f5
to
db5f8ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
requires #10073
Fixes #9453