Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(big_file_upload_configuration) Note new Apache LimitRequestBody default #10989

Merged
merged 1 commit into from
Aug 12, 2023
Merged

(big_file_upload_configuration) Note new Apache LimitRequestBody default #10989

merged 1 commit into from
Aug 12, 2023

Conversation

joshtrichards
Copy link
Member

@joshtrichards joshtrichards commented Aug 11, 2023 •
edited
Loading

  • Context:
    • Apache's default for LimitRequestBody changed from 0 (unlimited) to 1 GiB in v2.4.53 which was released on June 08, 2022. This is becoming a more widely deployed version (e.g. Debian 12 currently ships with v2.4.57 and Ubuntu kinentic/22.10 ships with v2.4.54)
    • See https://httpd.apache.org/docs/current/en/mod/core.html#limitrequestbody where this change in behavior is documented
    • Impacts non-chunking client transactions (effectively restricting them to <1GB)
  • Documents this in the Admin Manual in the Uploading big files > 512MB section were this parameter is already mentioned
  • Gives the reader some guidance so that they may decide what value makes the most sense in their local environment

☑️ Resolves

Follow-up Notes

  • Since this parameter can be used in .htaccess it may make sense to explore whether overriding Apache's new default makes sense to do in server, but that's outside the scope of documentation

🖼️ Screenshots

image

(Ignore black background; just by browser config)

@joshtrichards
(big_file_upload_configuration) Note new Apache LimitRequestBody default
f9c4a3f 
Apache's default for this changed from 0 (unlimited) to 1 GiB. This impacts non-chunking client transactions.

Resolves: #35778 and #37695 and documents needed adjustments applicable to various others like nextcloud/docker#1796

Signed-off-by: Josh Richards <[email protected]>
@szaimen szaimen added this to the Nextcloud 28 milestone Aug 12, 2023
@szaimen szaimen enabled auto-merge August 12, 2023 07:57
@szaimen szaimen merged commit 4537c70 into nextcloud:master Aug 12, 2023
8 checks passed
@Etienne-Schmitt Etienne-Schmitt mentioned this pull request Aug 14, 2023
Closed
@adripo adripo mentioned this pull request Sep 13, 2023
Merged
@henryk henryk mentioned this pull request Sep 14, 2023
Closed
@joshtrichards
Copy link
Member Author

/backport stable27

@szaimen
Copy link
Contributor

szaimen commented Oct 3, 2023

The syntax is /backport to branch

@joshtrichards
Copy link
Member Author

/backport to stable27

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 3, 2023
Merged
@joshtrichards joshtrichards mentioned this pull request Nov 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szaimen szaimen szaimen approved these changes

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
Nextcloud 28
Development

Successfully merging this pull request may close these issues.

Document new Apache LimitRequestBody Default
2 participants
@joshtrichards @szaimen