Bugfix/delete read only remnants folders

[mgallien]

No description provided.

[mgallien]

popup asking for delete confirmation

[mgallien]

@nextcloud/designers can you help with the UI review ? 🙏

[marcoambrosini]

@mgallien you mean review of this popup dialog? Are those windows standard components?

[mgallien]

@mgallien you mean review of this popup dialog? Are those windows standard components?

yes the popup screenshot would show the message
the components are standard ones and should follow the platform style (or way to show this type of popup)

@marcoambrosini I am more concerned by the content of the message and if you have suggestions about it

[marcoambrosini]

Got it @mgallien, I have to admit I don't understand exactly what's going on there. Could you explain the context with a bit more detail so that I can help with the text? :)

[mgallien]

/backport to stable-3.14

[mgallien]

/backport to stable-3.13

[mgallien]

Got it @mgallien, I have to admit I don't understand exactly what's going on there. Could you explain the context with a bit more detail so that I can help with the text? :)

@marcoambrosini
we had a bug were desktop client could leave folders that are read-only inside a read-only parent folder
those folders should have been deleted
we now detect them and ask the user confirmation before cleaning them up
not cleaning them is causing synchronization errors so the user would probably care and look at the dialog when it pops up

[jancborchardt]

we now detect them and ask the user confirmation before cleaning them up
not cleaning them is causing synchronization errors so the user would probably care and look at the dialog when it pops up

@mgallien @claucambra @camilasan in these cases we should automatically clear it up. Reading this popup I only see possible confusion, and no reason to not click the "Remove remnant folders" button.

We need to do as many things as possible automatically. Every time we ask people something, it can:

• Be missed
• Be misunderstood
• Lead to confusion
• Lead to frustration why it’s not understandable
• etc.

(Similar thing with the "spaces at end of filenames" issue for example.)

[marcoambrosini]

not cleaning them is causing synchronization errors so the user would probably care and look at the dialog when it pops up

Do you think we can perform this action without asking once we detect that folders that should have been deleted are in fact still there? cc @jancborchardt

edit: just saw your comment after refreshing Jan :)

[mgallien]

@jancborchardt
I agree with your points
I initially added this as I received feedback from some users that were worried about the delete operation
I will remove the dialog and indeed make sure the client is doing its best to ensure a working state with synchronization be in a working state

[mgallien]

you can review again
i tested with the removal of dialog and it is still working fine

[jancborchardt]

If there is no dialog, all good from my side. :) Thanks @mgallien!

[sonarcloud]

Quality Gate failed

Failed conditions
76.6% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)
80 New Code Smells (required ≤ 0)
1 New Bugs (required ≤ 0)
C Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

[nextcloud-desktop-bot]

AppImage file: nextcloud-PR-7061-8faefc6fa28d9a4bf956ec074cc6f9b60975eb88-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.