Use 'FindMimeFromData' from Win API instead of QMimeDatabase() functions to get the mimetype. Prevents freeze from VFS placeholders. #6458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/backport to stable-3.12 |
allexzander
force-pushed
the
bugfix/caseclashconflict-dialog-vfsmode-freeze
branch
2 times, most recently
from
d56765e
to
8276351
Compare
mgallien
requested changes
Feb 20, 2024
allexzander
force-pushed
the
bugfix/caseclashconflict-dialog-vfsmode-freeze
branch
from
9a432f7
to
a87f067
Compare
|
@mgallien it works, fixed, also, the other change is needed, because we end up having paths with double '/' |
mgallien
approved these changes
Feb 22, 2024
…ze from VFS placeholders. Signed-off-by: alex-z <[email protected]>
mgallien
force-pushed
the
bugfix/caseclashconflict-dialog-vfsmode-freeze
branch
from
a87f067
to
8aaa0d4
Compare
|
|
AppImage file: nextcloud-PR-6458-8aaa0d4c135f5a78cb57436a96c55d6b40fd58f3-x86_64.AppImage |
allexzander
deleted the
bugfix/caseclashconflict-dialog-vfsmode-freeze
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Similar, to how we had an issue with
.lnkfiles (https://doc.qt.io/qt-6/qfileinfo.html#symbolic-links-and-shortcuts) on Windows with VFS mode on, we now have a freeze when trying to get mime-type for a non-hydrated(online-only) file in CaseClash conflict resolution dialog. This PR switches to using a Windows API-specific function to get the mime-type (same result as with QMimeDatabase() but without causing a freeze on placeholder files).