Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clean up some qml code for share dialog #6425

Merged
merged 4 commits into from
Feb 13, 2024
Merged

clean up some qml code for share dialog #6425

merged 4 commits into from
Feb 13, 2024

Commits on Feb 13, 2024

  1. fix binding loop with palette assignments 

    Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    2a5e273 View commit details
    Browse the repository at this point in the history

  2. ensure role hideDownload from ShareModel has a boolean default value 

    Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    e24da81 View commit details
    Browse the repository at this point in the history

  3. fix QML warnings about accessing undefined parent property 

    we are defining a component, by definition there will be no parent

setting the size if the responsibility of the stack view, not of the
component (or even its definition)

Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    997ff65 View commit details
    Browse the repository at this point in the history

  4. fix more issues from qml in share dialog 

    Signed-off-by: Matthieu Gallien <[email protected]>
    @mgallien
    mgallien committed Feb 13, 2024
    Configuration menu
    Copy the full SHA
    4f2988a View commit details
    Browse the repository at this point in the history