Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a configuration interface for macOS File Provider virtual files #6351

Merged
merged 144 commits into from
Feb 19, 2024
Merged

Add a configuration interface for macOS File Provider virtual files #6351

merged 144 commits into from
Feb 19, 2024

Commits on Feb 19, 2024

  1. Add mac-specific virtual files settings section 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    35659bb View commit details
    Browse the repository at this point in the history

  2. Add basic, start FileProviderSettings page 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e547ae2 View commit details
    Browse the repository at this point in the history

  3. Add a start fileprovidersettingscontroller 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8643acf View commit details
    Browse the repository at this point in the history

  4. Set up QML file provider settings within the FileProviderSettingsCont… 

    …roller

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a6f15ea View commit details
    Browse the repository at this point in the history

  5. Use file provider settings controller in settings dialog 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    40389a2 View commit details
    Browse the repository at this point in the history

  6. Add basic fitting styling for FileProviderSettings component 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    dae1643 View commit details
    Browse the repository at this point in the history

  7. Expose QML engine in systray 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4b8338c View commit details
    Browse the repository at this point in the history

  8. Simplify widget creation of file provider settings UI 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    346a076 View commit details
    Browse the repository at this point in the history

  9. Make settings page use other internal QML components, correct palette 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    58e6385 View commit details
    Browse the repository at this point in the history

  10. Resize settings object to root view 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f158e27 View commit details
    Browse the repository at this point in the history

  11. Wrap normal folder settings in tab widget 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    5af363a View commit details
    Browse the repository at this point in the history

  12. Make sure qtabwidget in account settings is unnoticeable when file pr… 

    …ovider module is disabled

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c57a582 View commit details
    Browse the repository at this point in the history

  13. Move disguising of tab widget into separate method 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d4fb1e7 View commit details
    Browse the repository at this point in the history

  14. Remove Virtual files section of settings, move this instead to indivi… 

    …dual tab in each account page

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    174d3ec View commit details
    Browse the repository at this point in the history

  15. Implement basic layout for file provider configuration UI 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8070dbd View commit details
    Browse the repository at this point in the history

  16. Make file provider settings controller implementation an Objective-C+… 

    …+ file

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f607bfa View commit details
    Browse the repository at this point in the history

  17. Add access to FileProviderSettingsController in FileProviderSettings … 

    …page

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2863415 View commit details
    Browse the repository at this point in the history

  18. Add starter FileProviderSettings objective c class 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7e4d643 View commit details
    Browse the repository at this point in the history

  19. Add MacImplementation private class to interface with obj-c settings API 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    27c803a View commit details
    Browse the repository at this point in the history

  20. Instantiate internal MacImplementation in file provider settings cont… 

    …roller

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d80962b View commit details
    Browse the repository at this point in the history

  21. Lazily load settings view widget 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0e02a64 View commit details
    Browse the repository at this point in the history

  22. Make the fp settings controller static 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    20f89c6 View commit details
    Browse the repository at this point in the history

  23. Treat FileProviderSettingsController::settingsViewWidget as a factory… 

    … method

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    94ce3da View commit details
    Browse the repository at this point in the history

  24. Make it possible to check whether an account has vfs enabled or not 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c69bb43 View commit details
    Browse the repository at this point in the history

  25. Implement modification of file provider enabled for account 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9a880f4 View commit details
    Browse the repository at this point in the history

  26. Use default constructor for FileProviderSettingsController::MacImplem… 

    …entation

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ac608a6 View commit details
    Browse the repository at this point in the history

  27. Notify when enabled file provider vfs accounts change 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3c26e25 View commit details
    Browse the repository at this point in the history

  28. Expose account user id with host to QML 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ba3baa4 View commit details
    Browse the repository at this point in the history

  29. Register file provider settings controller as singleton in qml engine 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a57cb3d View commit details
    Browse the repository at this point in the history

  30. Set account as property of settings view root object rather than cont… 

    …ext property

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e9451e9 View commit details
    Browse the repository at this point in the history

  31. Move fp settings controller out of ui folder 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    556bce2 View commit details
    Browse the repository at this point in the history

  32. Use [[nodiscard]] for MacImplementation methods 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    42b72f9 View commit details
    Browse the repository at this point in the history

  33. Add method to enable file provider vfs for all accounts 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    5f059a2 View commit details
    Browse the repository at this point in the history

  34. Run initial check on creation of FileProviderSettingsController 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f5b80e9 View commit details
    Browse the repository at this point in the history

  35. Ensure account is file provider vfs enablement is correctly set in NS… 

    …UserDefaults

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    58262a8 View commit details
    Browse the repository at this point in the history

  36. Init widely-used variables in MacImplementation at declaration, fix n… 

    …ullability warnings

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0c40cef View commit details
    Browse the repository at this point in the history

  37. Remove ConfigFile().macFileProviderModuleEnabled() config flag 

    Since we are going to distribute the file provider client as separate
from the normal client, this flag doesn't make any practical sense.
The user using the FileProvider desktop client will not want to not
use the file provider module

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1db59fe View commit details
    Browse the repository at this point in the history

  38. Enable file provider domains per the settings in the file provider do… 

    …main manager

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ee6c081 View commit details
    Browse the repository at this point in the history

  39. Separate file provider domain updating into separate slot 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    15525bc View commit details
    Browse the repository at this point in the history

  40. Update file provider domain enablement status upon settings change 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e4aeb5b View commit details
    Browse the repository at this point in the history

  41. Do not bother trying to add a fp domain if we know it is active 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    5aa7138 View commit details
    Browse the repository at this point in the history

  42. Remove fp domain id from registered domains when removal is confirmed 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    97c963d View commit details
    Browse the repository at this point in the history

  43. Add starter fileproviderstorageuseenumerationobserver 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b83f0a5 View commit details
    Browse the repository at this point in the history

  44. Define ompletion block for fileproviderstorageuseenumerationobserver 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    435e25d View commit details
    Browse the repository at this point in the history

  45. Calculate total storage use from enumerator for materialised files in… 

    … fileproviderstorageuseenumerationobserver

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    8fdc69b View commit details
    Browse the repository at this point in the history

  46. Fetch materialised files storage usage per account on creation of Fil… 

    …eProviderSettingsController

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2105596 View commit details
    Browse the repository at this point in the history

  47. Expose local storage usage for account in gigabytes to QML 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    18ed46e View commit details
    Browse the repository at this point in the history

  48. Use NSUInteger directly when calculationg usage in FileProviderStorag… 

    …eUseEnumerationObserver

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9105a45 View commit details
    Browse the repository at this point in the history

  49. Hold a strong reference to UsageEnumerationFinishedHandler 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    22a521d View commit details
    Browse the repository at this point in the history

  50. Handle edge cases with materialised files enumeration and improve log… 

    …ging

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    4e8eab6 View commit details
    Browse the repository at this point in the history

  51. Move GB with decimal number calculation to function 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7d229b5 View commit details
    Browse the repository at this point in the history

  52. Fetch and store user info for accounts in file provider settings cont… 

    …roller

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f68965a View commit details
    Browse the repository at this point in the history

  53. Add property to file provider settings controller displaying remote f… 

    …ile storage usage

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    679177e View commit details
    Browse the repository at this point in the history

  54. Fix positioning fo elements in FileProviderSettings UI 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    02b47b4 View commit details
    Browse the repository at this point in the history

  55. Leave usage as a property of materialised files enumerator 

    Do this instead of passing as variable in completion handler

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0b8a231 View commit details
    Browse the repository at this point in the history

  56. Keep track of materialised files in storageuseenumerationobserver 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c3490db View commit details
    Browse the repository at this point in the history

  57. Store materialised file metadata in file provider settings controller 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fec9902 View commit details
    Browse the repository at this point in the history

  58. Add a Qt-based data class for file provider items 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    57d1dc8 View commit details
    Browse the repository at this point in the history

  59. Add a convenience function to convert from nsnamecomponents to qstring 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a34a390 View commit details
    Browse the repository at this point in the history

  60. Add convenience function to convert extendedAttributes to QHash 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e3a0dab View commit details
    Browse the repository at this point in the history

  61. Add static convenience method to FileProviderItemMetadata to convert … 

    …from NSFileProviderItem

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    134eae6 View commit details
    Browse the repository at this point in the history

  62. Add method to get qtified file provider item metadata for account in … 

    …FileProviderSettingsController

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    389e663 View commit details
    Browse the repository at this point in the history

  63. Add starter FileProviderMaterialisedItemsModel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    269fb03 View commit details
    Browse the repository at this point in the history

  64. Add custom equality check to FileProviderItemMetadata 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    726503f View commit details
    Browse the repository at this point in the history

  65. Set FileProviderItemMetadata vector in materialised items model 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f90f86d View commit details
    Browse the repository at this point in the history

  66. Emit signal when materialised items for an account change 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    85b3a13 View commit details
    Browse the repository at this point in the history

  67. Add method to generate materialised item models in settings controller 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c1a5e78 View commit details
    Browse the repository at this point in the history

  68. Add method to generate eviction of materialised item windows in setti… 

    …ngs controller

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2ce4e91 View commit details
    Browse the repository at this point in the history

  69. Add starter FileProviderEvictionDialog component 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    af98e48 View commit details
    Browse the repository at this point in the history

  70. Add a general actions grid to the settings qml component to enable us… 

    …ers to manage storage usage

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d51c2a4 View commit details
    Browse the repository at this point in the history

  71. Add additional roles to FileProviderMaterialisedItemsModel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    89bb008 View commit details
    Browse the repository at this point in the history

  72. Add rolenames for FileProviderMaterialisedItemsModel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    bfaba67 View commit details
    Browse the repository at this point in the history

  73. Ensure correct index is set on hidden tab widget 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f254714 View commit details
    Browse the repository at this point in the history

  74. Keep track of item metadata's parent domain identifier 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ad2baea View commit details
    Browse the repository at this point in the history

  75. Add method to get user visible path for an item metadata 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e03edc1 View commit details
    Browse the repository at this point in the history

  76. Get and set userVisiblePath at item metadata construction time 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    beb889c View commit details
    Browse the repository at this point in the history

  77. Add UserVisiblePathRole to FileProviderMaterialisedItemsModel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f060f0c View commit details
    Browse the repository at this point in the history

  78. Add a user-understandable file type string to itemmetadata 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    371257a View commit details
    Browse the repository at this point in the history

  79. Add file type role to FileProviderMaterialisedItemsModel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b3c7575 View commit details
    Browse the repository at this point in the history

  80. Add basic FileProviderFileDelegate UI component 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    da20e7e View commit details
    Browse the repository at this point in the history

  81. Add method to evict an item in FileProviderMaterialisedItemsModel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0b961e9 View commit details
    Browse the repository at this point in the history

  82. Expose items' domain identifier in FileProviderMaterialisedItemsModel 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    c763a9a View commit details
    Browse the repository at this point in the history

  83. Enable use of "Delete" button in FileProviderFileDelegate to evict item 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d905f13 View commit details
    Browse the repository at this point in the history

  84. Fix layout for FileProviderFileDelegate 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    64e1166 View commit details
    Browse the repository at this point in the history

  85. Add fileproviderutils namespace 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ba2bef2 View commit details
    Browse the repository at this point in the history

  86. Add convenience function to FileProviderUtils to get manager for a gi… 

    …ven domain identifier

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b47665e View commit details
    Browse the repository at this point in the history

  87. Separate domain finding into separate function in FileProviderUtils 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    44a6f46 View commit details
    Browse the repository at this point in the history

  88. Use FileProviderUtils function to get manager for domain id in FilePr… 

    …oviderItemMetadata

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b23e6bc View commit details
    Browse the repository at this point in the history

  89. Use FileProviderUtils function to get manager from domain id in FileP… 

    …roviderMaterialisedItemsModel

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    84d8561 View commit details
    Browse the repository at this point in the history

  90. Fix retain crash when calling managerForDomain 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    643d30a View commit details
    Browse the repository at this point in the history

  91. Display file sizes as nicely formatted string in file provider file d… 

    …elegate

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f22bf9e View commit details
    Browse the repository at this point in the history

  92. Improve visuals of file delegate details UI 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    5c3cd69 View commit details
    Browse the repository at this point in the history

  93. Have backup for 0 value in itemmetadata documentsize in materialised … 

    …items model

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a204f11 View commit details
    Browse the repository at this point in the history

  94. Provide feedback when materialised item eviction fails 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    cfbdf3a View commit details
    Browse the repository at this point in the history

  95. Update the materialised items model post-file eviction 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b9cf135 View commit details
    Browse the repository at this point in the history

  96. Add function to retrieve log entries in File provider Logger extension 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0ddd22d View commit details
    Browse the repository at this point in the history

  97. Add function to File Provider Logger extension to create debug logs file 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1dcfee4 View commit details
    Browse the repository at this point in the history

  98. Add public convenience static method to get domainIdentifier from a g… 

    …iven accountState

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    0a5df3b View commit details
    Browse the repository at this point in the history

  99. Add convenience method in FileProvider to send a message to a given f… 

    …ile provider domain

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    292ff9b View commit details
    Browse the repository at this point in the history

  100. Add createFileProvider slot to FileProviderSettingsController 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    24dda9b View commit details
    Browse the repository at this point in the history

  101. Add button to create debug archive 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9733c11 View commit details
    Browse the repository at this point in the history

  102. Implement creating debug archive in client communication service 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    70521e9 View commit details
    Browse the repository at this point in the history

  103. Replace old and now broken socket based debug archive command with co… 

    …mmand over XPC

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b2e5659 View commit details
    Browse the repository at this point in the history

  104. Directly provide text file path to logger for debug archive creation 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    571b1ca View commit details
    Browse the repository at this point in the history

  105. Replace handling of debug archive creation in clientcommunicationserv… 

    …ice with simple retrieval of debug string

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9946495 View commit details
    Browse the repository at this point in the history

  106. Create debug archive on client side 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    62bbf6a View commit details
    Browse the repository at this point in the history

  107. Mark MacImplementation constructor for FileProviderSettingsController… 

    … as explicit

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6a0f76d View commit details
    Browse the repository at this point in the history

  108. Directly generate file provider item metadatas and cache 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fd95ab7 View commit details
    Browse the repository at this point in the history

  109. Remove unused usage property from enumeration observer 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3b179cc View commit details
    Browse the repository at this point in the history

  110. Always perform fallback document size discovery in fileprovideritemme… 

    …tadata

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1d01f67 View commit details
    Browse the repository at this point in the history

  111. Add method to signal file provider domain via file provider settings … 

    …controller

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f1c7811 View commit details
    Browse the repository at this point in the history

  112. Add UI button to signal file provider domain 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    369c1d7 View commit details
    Browse the repository at this point in the history

  113. Add starter FileProviderDomainSyncStatus 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7a9a17a View commit details
    Browse the repository at this point in the history

  114. Define basic FileProviderDomainSyncStatus private implementation 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    62c85de View commit details
    Browse the repository at this point in the history

  115. Add q pointer to MacImplementation for FileProviderDomainSyncStatus 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    fe6d03a View commit details
    Browse the repository at this point in the history

  116. Add a starter ProgressObserver Objective-C class 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6fa969d View commit details
    Browse the repository at this point in the history

  117. Acquire upload/download progress in domain sync status 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    e314fd0 View commit details
    Browse the repository at this point in the history

  118. Add ProgressKVOChangeHandler property to ProgressObserver 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    13b0244 View commit details
    Browse the repository at this point in the history

  119. Add observing for important properties of nsprogress in progresshandler 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    d387eb9 View commit details
    Browse the repository at this point in the history

  120. Add main properties to FileProviderDomainSyncStatus 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f881c1d View commit details
    Browse the repository at this point in the history

  121. Update properties via ProgressObserver on FileProviderDomainSyncStatus 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    6d9c445 View commit details
    Browse the repository at this point in the history

  122. Fix parameter name shadowing in fraction completed methods of domain … 

    …sync status

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    78732bf View commit details
    Browse the repository at this point in the history

  123. Fix unique ptr compile issue in domain sync status 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    21a317c View commit details
    Browse the repository at this point in the history

  124. Make mac implementation of file provider settings controller a QObject 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9774ac6 View commit details
    Browse the repository at this point in the history

  125. Setup domain sync statuses in settings controller 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9ca418c View commit details
    Browse the repository at this point in the history

  126. Add method to acquire domain sync status in settings controller 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    36001ae View commit details
    Browse the repository at this point in the history

  127. Fix crash on state change in file provider domain sync status 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    f8ebbe8 View commit details
    Browse the repository at this point in the history

  128. Enable use of domain sync status class in QML 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    9e235f9 View commit details
    Browse the repository at this point in the history

  129. Add current sync status UI to file provider settings view 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    3060ff6 View commit details
    Browse the repository at this point in the history

  130. Only load file provider settings items if domain is enabled 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    2f752a6 View commit details
    Browse the repository at this point in the history

  131. Extract sync status layout to separate file 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b9ae82c View commit details
    Browse the repository at this point in the history

  132. Extract File Provider storage settings to separate file 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    ed12541 View commit details
    Browse the repository at this point in the history

  133. Fix grid layout for sync status of file provider 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    034822f View commit details
    Browse the repository at this point in the history

  134. Add separator to dynamically loaded fp settings 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7b99a06 View commit details
    Browse the repository at this point in the history

  135. Bolden sync state text for fp 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    7d8778d View commit details
    Browse the repository at this point in the history

  136. Provide correct sync state icon in file provider domain sync status 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a469d44 View commit details
    Browse the repository at this point in the history

  137. Add useful font sizes to Style.qml 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    472bba8 View commit details
    Browse the repository at this point in the history

  138. Use font sizes in Style.qml in FileProviderSettings 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    918e411 View commit details
    Browse the repository at this point in the history

  139. Adjust alignment and sizing of file provider sync status icon 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    1f70c85 View commit details
    Browse the repository at this point in the history

  140. Use NCProgressBar for file provider sync status 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    81d4aa7 View commit details
    Browse the repository at this point in the history

  141. Limit gigabyte sizing string to two decimal figures in file provider … 

    …storage info

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    a428256 View commit details
    Browse the repository at this point in the history

  142. Ensure [[nodiscard]] in new file provider classes 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    b4e1338 View commit details
    Browse the repository at this point in the history

  143. Mark MacImplementation for FileProviderSettings destructor as override 

    Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    28cfd8f View commit details
    Browse the repository at this point in the history

  144. Temporarily remove eviction dialog button until eviction works on ext… 

    …ension side

Signed-off-by: Claudio Cambra <[email protected]>
    @claucambra
    claucambra committed Feb 19, 2024
    Configuration menu
    Copy the full SHA
    92a1d80 View commit details
    Browse the repository at this point in the history