-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix/autostart #6342
Bugfix/autostart #6342
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
9e7c738
to
02b1bce
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-Tidy
found issue(s) with the introduced code (1/1)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, only one insignificant nitpick
82f9e10
to
c7917d9
Compare
3e58066
to
89c82bc
Compare
/backport to stable-3.11 |
89c82bc
to
2c3738b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
build fail if we define TOKEN_AUTH_ONLY
cmake option to ON
that said, |
Set autostart default to true. Signed-off-by: Camila <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Previously, deprecated API was used to tell macOS to launch the GUI when the user logs in. This has now been moved to launchd, which uses the contents of the file ~/Library/LaunchAgents/com.owncloud.desktopclient.plist to determine what to do. This comes with the added benefit that wel now tell launchd to relaunch the client when it crashes. Fixes: #9037 Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Case-sensitive compares will give problems when a launchd plist file exists, but the executable gets upated, and the name only has a different case (e.g.: owncloud -> ownCloud). Signed-off-by: Camila Ayres <[email protected]>
When the crash is due to a library load failure while starting, having this turned on would result in an endless loop of crash-restarts. Fixes: #9800 Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Instead of using a dictionary for the value of KeepAlive, setting it to @no will keep launchd from relaunching the client. Signed-off-by: Camila Ayres <[email protected]>
Signed-off-by: Camila Ayres <[email protected]>
Make sure to migrate older configs to have the value set to true. Signed-off-by: Camila Ayres <[email protected]>
…ll cases. Signed-off-by: Camila Ayres <[email protected]>
2c3738b
to
2089fb1
Compare
/backport to stable-3.10 |
Quality Gate failedFailed conditions 19.4% Coverage on New Code (required ≥ 80%) See analysis details on SonarCloud Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
AppImage file: nextcloud-PR-6342-2089fb168bcfdeab3d7f2df50bfaf830689b2d73-x86_64.AppImage |
No description provided.