Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/autostart #6342

Merged
merged 13 commits into from
Jan 22, 2024
Merged

Bugfix/autostart #6342

merged 13 commits into from
Jan 22, 2024

Conversation

camilasan
Copy link
Member

No description provided.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/common/utility_mac.cpp Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Clang-Tidy found issue(s) with the introduced code (1/1)

src/common/utility_mac.mm Show resolved Hide resolved
Copy link
Collaborator

@claucambra claucambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, only one insignificant nitpick

src/common/utility_mac.mm Outdated Show resolved Hide resolved
@camilasan camilasan force-pushed the bugfix/autostart branch 4 times, most recently from 82f9e10 to c7917d9 Compare January 14, 2024 19:24
@camilasan camilasan marked this pull request as ready for review January 18, 2024 14:17
@camilasan camilasan force-pushed the bugfix/autostart branch 2 times, most recently from 3e58066 to 89c82bc Compare January 18, 2024 14:52
@camilasan
Copy link
Member Author

/backport to stable-3.11

Copy link
Collaborator

@mgallien mgallien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build fail if we define TOKEN_AUTH_ONLY cmake option to ON

src/common/utility_unix.cpp Outdated Show resolved Hide resolved
src/common/utility_win.cpp Outdated Show resolved Hide resolved
src/common/utility_mac.mm Show resolved Hide resolved
src/gui/generalsettings.cpp Outdated Show resolved Hide resolved
@mgallien
Copy link
Collaborator

build fail if we define TOKEN_AUTH_ONLY cmake option to ON

that said, master branch compilation is also broken if we define TOKEN_AUTH_ONLY to ON when configuring the build with cmake
meaning, I would not use this macro in modified/new code given the brokenness

Camila and others added 13 commits January 22, 2024 11:27
Set autostart default to true.

Signed-off-by: Camila <[email protected]>
Previously, deprecated API was used to tell macOS to launch the GUI when
the user logs in. This has now been moved to launchd, which uses the
contents of the file
~/Library/LaunchAgents/com.owncloud.desktopclient.plist to determine
what to do. This comes with the added benefit that wel now tell launchd
to relaunch the client when it crashes.

Fixes: #9037
Signed-off-by: Camila Ayres <[email protected]>
Case-sensitive compares will give problems when a launchd plist file
exists, but the executable gets upated, and the name only has a
different case (e.g.: owncloud -> ownCloud).

Signed-off-by: Camila Ayres <[email protected]>
When the crash is due to a library load failure while starting, having
this turned on would result in an endless loop of crash-restarts.

Fixes: #9800

Signed-off-by: Camila Ayres <[email protected]>
Instead of using a dictionary for the value of KeepAlive, setting it to
@no will keep launchd from relaunching the client.

Signed-off-by: Camila Ayres <[email protected]>
Make sure to migrate older configs to have the value set to true.

Signed-off-by: Camila Ayres <[email protected]>
@mgallien mgallien merged commit 9f9c9fc into master Jan 22, 2024
7 of 10 checks passed
@mgallien mgallien deleted the bugfix/autostart branch January 22, 2024 10:52
@camilasan
Copy link
Member Author

/backport to stable-3.10

Copy link

sonarcloud bot commented Jan 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

19.4% Coverage on New Code (required ≥ 80%)
B Maintainability Rating on New Code (required ≥ A)
17 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

idea Catch issues before they fail your Quality Gate with our IDE extension SonarLint SonarLint

@nextcloud-desktop-bot
Copy link

AppImage file: nextcloud-PR-6342-2089fb168bcfdeab3d7f2df50bfaf830689b2d73-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.

@mgallien mgallien added this to the 3.12.0 milestone Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants