Windows: Additional write permissions check

src/gui/folderman.cpp

@@ -1,4 +1,4 @@
 /*
  * Copyright (C) by Klaas Freitag <[email protected]>
  *
  * This program is free software; you can redistribute it and/or modify
@@ -1701,9 +1701,29 @@
         return FolderMan::tr("The selected path is not a folder!");
     }
 
+    #ifdef Q_OS_WIN
+    if (!selFile.isWritable()) {
+        // isWritable() doesn't cover all NTFS permissions
+        // Try write
+        const auto testPath = selFile.dir().filePath("nextcloud-write-test-file.txt");
+        const auto fp = fopen(testPath.c_str(), "w");
+        if (!fp) {
+            return FolderMan::tr("You have no permission to write to the selected folder!");
+        }
+        fclose(fp);
+
+        // Try delete
+        const auto rc = remove(testPath.c_str());
+        if (rc) {
+            return FolderMan::tr("You have no permission to write to the selected folder!");
+        }
+    }
+    #else
     if (!selFile.isWritable()) {
         return FolderMan::tr("You have no permission to write to the selected folder!");
     }
+    #endif
+
     return QString();
 }