fix general section

[jospoortvliet]

This PR fixes 3 things in the documentation of the config file.

• First, there is a table that has gone missing in our documentation due to a formatting error. It is now back.
• Second, it fixes the targetChunkUploadDuration value for chunking that was described to be defaulting to 6000 (10 seconds) instead of the reality, which is 60000 (1 minute)
• Third, it adds a short section in the Troubleshooting file about the Cloudflare issues users have been having, where the connection is abruptly closed because Cloudflare DNS blocks uploads >100 mb.

Ideally, the chunking algorithm considers a closed connection as similar to a connection exceeding its targetChunkUploadDuration, decreasing the chunk size again and therefor still succeeding in uploading a file. This can probably be fixed relatively easy, and beats a documentation change, but I can only change documentation, not code.

So with this PR we now explain how people can manually lower the chunk size, which can be helpful in other situations too.

See #4278 (comment)

Signed-off-by: jos poortvliet [email protected]

[jospoortvliet]

I have one open question with regards to this code/documentation, see the issue:

People report that setting
targetChunkUploadDuration=6000
Fixes their problem.

Now that makes no sense, as the docs say that that IS the default. Looking at the code, it does something that - well, it's no surprise I don't understand it, but pls double check if that indeed leads to 6000 please ;-)

qint64 ConfigFile::minChunkSize() const
{
    QSettings settings(configFile(), QSettings::IniFormat);
    return settings.value(QLatin1String(minChunkSizeC), 1000 * 1000).toLongLong(); // default to 1 MB
}

chrono::milliseconds ConfigFile::targetChunkUploadDuration() const
{
    QSettings settings(configFile(), QSettings::IniFormat);
    return millisecondsValue(settings, targetChunkUploadDurationC, chrono::minutes(1));
}

[Gwindalmir]

The default according to the log files is 60000 (1 minute).

2022-04-14 11:09:41:146 [ info nextcloud.sync.propagator.upload.ng C:\Users\sysadmin\AppData\Local\Temp\2\windows-9586\client-building\desktop\src\libsync\propagateuploadng.cpp:418 ]: Chunked upload of 10000000 bytes took 2552 ms, desired is 60000 ms, expected good chunk size is 235109717 bytes and nudged next chunk size to 122554858 bytes

[jospoortvliet]

The default according to the log files is 60000 (1 minute).

2022-04-14 11:09:41:146 [ info nextcloud.sync.propagator.upload.ng C:\Users\sysadmin\AppData\Local\Temp\2\windows-9586\client-building\desktop\src\libsync\propagateuploadng.cpp:418 ]: Chunked upload of 10000000 bytes took 2552 ms, desired is 60000 ms, expected good chunk size is 235109717 bytes and nudged next chunk size to 122554858 bytes

Good catch, updated!

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[mgallien]

/backport to stable-3.5

[camilasan]

@jospoortvliet please remove the merge commits.

[claucambra]

DCO is failing, please sign-off the commits :)

[claucambra]

DCO is failing, please sign-off the commits :)

@jospoortvliet Ping? :)

[sonarcloud]

Kudos, SonarCloud Quality Gate passed!   

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
No Duplication information

[codecov]

Codecov Report

Merging #4439 (71dbd11) into master (af93a98) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #4439      +/-   ##
==========================================
- Coverage   56.42%   56.42%   -0.01%     
==========================================
  Files         138      138              
  Lines       17071    17071              
==========================================
- Hits         9633     9632       -1     
- Misses       7438     7439       +1     

Impacted Files	Coverage Δ
src/libsync/propagatedownload.cpp	65.18% <0.00%> (-0.15%)	⬇️

[nextcloud-desktop-bot]

AppImage file: Nextcloud-PR-4439-71dbd1103f96ea909e79e8c2d4f87331b248d73a-x86_64.AppImage

To test this change/fix you can simply download above AppImage file and test it.

Please make sure to quit your existing Nextcloud app and backup your data.