Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Better handle network errors #4955

Closed
4 of 8 tasks
mgallien opened this issue Sep 19, 2022 · 0 comments · Fixed by #5036
Closed
4 of 8 tasks

[Bug]: Better handle network errors #4955

mgallien opened this issue Sep 19, 2022 · 0 comments · Fixed by #5036
Assignees
Labels
0. Needs triage approved bug approved by the team

Comments

@mgallien
Copy link
Collaborator

⚠️ Before submitting, please verify the following: ⚠️

Bug description

Network errors are currently showing as a big blocker error.
Even errors reported by Qt api as temp network errors will block sync and be reported as an error to the user with a big scary red icon.

Steps to reproduce

  1. Trigger sync
  2. Have a network disconnection (especially temporary one)
  3. See big scary errors pop up
  4. See sync starting again and finishing successfully when network connection is working again without user intervention

Expected behavior

We could do two things:

  • Wait until the same network error happen 3 times each occurrence separated by a minute before telling it to the user
  • Checks if Qt is really able to reliably detect that network is up or down and silence network errors if network is down (no need to tell it to the user given the operating system workspace is probably also showing it as a notification)

Which files are affected by this bug

n/a

Operating system

Mac OS

Which version of the operating system you are running.

macOS 13.0

Package

Other

Nextcloud Server version

24.0.4

Nextcloud Desktop Client version

3.5.82

Is this bug present after an update or on a fresh install?

Fresh desktop client install

Are you using the Nextcloud Server Encryption module?

Encryption is Disabled

Are you using an external user-backend?

  • Default internal user-backend
  • LDAP/ Active Directory
  • SSO - SAML
  • Other

Nextcloud Server logs

No response

Additional info

No response

@mgallien mgallien added 0. Needs triage approved bug approved by the team labels Sep 19, 2022
@mgallien mgallien self-assigned this Sep 19, 2022
@tobiasKaminsky tobiasKaminsky linked a pull request Oct 26, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0. Needs triage approved bug approved by the team
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant