Allocate new unsigned char buffer for processed line in heap, fixing …

…crash Signed-off-by: Claudio Cambra <[email protected]>
nextcloud · Jul 21, 2023 · 6a21c64 · 6a21c64
1 parent cd67afc
commit 6a21c64
Showing 1 changed file with 4 additions and 3 deletions.
diff --git a/shell_integration/MacOSX/NextcloudIntegration/NCDesktopClientSocketKit/LocalSocketClient.m b/shell_integration/MacOSX/NextcloudIntegration/NCDesktopClientSocketKit/LocalSocketClient.m
@@ -343,9 +343,10 @@ - (void)processInBuffer
 
         if (firstSeparatorIndex.location == NSNotFound) {
             NSLog(@"No separator found. Creating new buffer qith space for null terminator.");
-            unsigned char newBuffer[inBufferLength + 1];
-            memcpy(&newBuffer, buffer, inBufferLength);
-            buffer = &newBuffer[0];
+
+            unsigned char *newBuffer = malloc(sizeof(unsigned char) * (inBufferLength + 1));
+            memcpy(newBuffer, buffer, inBufferLength);
+            buffer = newBuffer;
             nullTerminatorIndex = inBufferLength;
         } else {
             nullTerminatorIndex = firstSeparatorIndex.location;