Back to pull request #5877

Feature/e2ee use hardware token secure storage #3947

Sign in to view logs

Summary
Jobs
- build
Run details
- Usage
- Workflow file

Triggered via pull request September 4, 2024 14:06

mgallien

synchronize #5877

feature/e2eeUseHardwareTokenSecureStorage

Status Success

Total duration 30m 16s

Artifacts –

clang-format.yml

on: pull_request

Annotations

10 errors, 10 warnings, and 10 notices

src/common/syncjournaldb.cpp:19:10 [clang-diagnostic-error]: src/common/syncjournaldb.cpp#L19

'QCryptographicHash' file not found

src/common/syncjournalfilerecord.h:22:10 [clang-diagnostic-error]: src/common/syncjournalfilerecord.h#L22

'QString' file not found

src/gui/accountsettings.h:18:10 [clang-diagnostic-error]: src/gui/accountsettings.h#L18

'QWidget' file not found

src/gui/connectionvalidator.cpp:15:10 [clang-diagnostic-error]: src/gui/connectionvalidator.cpp#L15

'QJsonDocument' file not found

src/gui/folder.cpp:16:10 [clang-diagnostic-error]: src/gui/folder.cpp#L16

'common/syncjournaldb.h' file not found

src/gui/tray/activitydata.h:18:10 [clang-diagnostic-error]: src/gui/tray/activitydata.h#L18

'syncfileitem.h' file not found

src/gui/tray/activitylistmodel.h:18:10 [clang-diagnostic-error]: src/gui/tray/activitylistmodel.h#L18

'QtCore' file not found

src/libsync/clientsideencryption.h:18:10 [clang-diagnostic-error]: src/libsync/clientsideencryption.h#L18

'owncloudlib.h' file not found

src/libsync/clientsideencryptionprimitives.h:17:10 [clang-diagnostic-error]: src/libsync/clientsideencryptionprimitives.h#L17

'QtCore/qglobal.h' file not found

src/libsync/discoveryphase.h:17:10 [clang-diagnostic-error]: src/libsync/discoveryphase.h#L17

'QObject' file not found

src/gui/accountsettings.cpp:342:16 [cppcoreguidelines-init-variables]: src/gui/accountsettings.cpp#L342

variable '_accountState' is not initialized

src/gui/accountsettings.cpp:1149:43 [bugprone-easily-swappable-parameters]: src/gui/accountsettings.cpp#L1149

2 adjacent parameters of 'showConnectionLabel' of similar type are easily swapped by mistake

src/gui/accountsettings.cpp:1526:23 [readability-convert-member-functions-to-static]: src/gui/accountsettings.cpp#L1526

method 'slotE2eEncryptionCertificateNeedMigration' can be made static

src/gui/accountsettings.cpp:1534:23 [readability-convert-member-functions-to-static]: src/gui/accountsettings.cpp#L1534

method 'updateBlackListAndScheduleFolderSync' can be made static

src/gui/systray.cpp:322:15 [readability-convert-member-functions-to-static]: src/gui/systray.cpp#L322

method 'createEncryptionTokenDiscoveryDialog' can be made static

src/gui/systray.cpp:340:15 [readability-convert-member-functions-to-static]: src/gui/systray.cpp#L340

method 'destroyEncryptionTokenDiscoveryDialog' can be made static

src/gui/systray.cpp:350:15 [modernize-use-trailing-return-type]: src/gui/systray.cpp#L350

use a trailing return type for this function

src/libsync/clientsideencryption.cpp:2906:1 [cppcoreguidelines-pro-type-member-init]: src/libsync/clientsideencryption.cpp#L2906

constructor does not initialize these fields: _privateKeyData, _certificate

src/libsync/clientsideencryption.cpp:2911:1 [cppcoreguidelines-pro-type-member-init]: src/libsync/clientsideencryption.cpp#L2911

constructor does not initialize these fields: _privateKeyData, _certificate

src/libsync/clientsideencryption.cpp:2919:1 [cppcoreguidelines-pro-type-member-init]: src/libsync/clientsideencryption.cpp#L2919

constructor does not initialize these fields: _privateKeyData, _certificate

Run clang-format on src/common/syncjournaldb.cpp: src/common/syncjournaldb.cpp#L1

File src/common/syncjournaldb.cpp does not conform to Custom style guidelines. (lines 51, 71, 992, 994)

Run clang-format on src/csync/csync.h: src/csync/csync.h#L1

File src/csync/csync.h does not conform to Custom style guidelines. (lines 141, 142, 143, 144, 145, 146, 147, 148, 149, 150, 151, 152, 153, 155, 157, 158)

Run clang-format on src/gui/accountsettings.cpp: src/gui/accountsettings.cpp#L1

File src/gui/accountsettings.cpp does not conform to Custom style guidelines. (lines 295, 296, 297, 298)

Run clang-format on src/gui/accountsettings.h: src/gui/accountsettings.h#L1

File src/gui/accountsettings.h does not conform to Custom style guidelines. (lines 65)

Run clang-format on src/gui/folder.cpp: src/gui/folder.cpp#L1

File src/gui/folder.cpp does not conform to Custom style guidelines. (lines 133)

Run clang-format on src/gui/owncloudgui.cpp: src/gui/owncloudgui.cpp#L1

File src/gui/owncloudgui.cpp does not conform to Custom style guidelines. (lines 145, 627)

Run clang-format on src/gui/settingsdialog.cpp: src/gui/settingsdialog.cpp#L1

File src/gui/settingsdialog.cpp does not conform to Custom style guidelines. (lines 214)

Run clang-format on src/gui/systray.cpp: src/gui/systray.cpp#L1

File src/gui/systray.cpp does not conform to Custom style guidelines. (lines 330)

Run clang-format on src/gui/systray.h: src/gui/systray.h#L1

File src/gui/systray.h does not conform to Custom style guidelines. (lines 200)

Run clang-format on src/gui/tray/activitylistmodel.cpp: src/gui/tray/activitylistmodel.cpp#L1

File src/gui/tray/activitylistmodel.cpp does not conform to Custom style guidelines. (lines 230, 372, 679, 680, 681, 682)