Skip to content

Commit

Permalink
fix: Fix spacing and reserved scrollbar space
Browse files Browse the repository at this point in the history
Signed-off-by: Julius Härtl <[email protected]>
  • Loading branch information
juliusknorr committed Nov 10, 2023
1 parent 8f8597d commit 41d1749
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 5 deletions.
1 change: 1 addition & 0 deletions src/components/board/Board.vue
Original file line number Diff line number Diff line change
Expand Up @@ -252,6 +252,7 @@ export default {
scrollbar-gutter: stable;
padding-top: 15px;
margin-top: -10px;
scrollbar-gutter: stable;
}
.smooth-dnd-container.vertical > .smooth-dnd-draggable-wrapper {
Expand Down
8 changes: 3 additions & 5 deletions src/components/board/Stack.vue
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,9 @@
<div v-click-outside="stopCardCreation"
class="stack__header"
:class="{'stack__header--add': showAddCard}"
tabindex="0"
:aria-label="stack.title">
<transition name="fade" mode="out-in">
<h3 v-if="!canManage || isArchived">
<h3 v-if="!canManage || isArchived" tabindex="0">
{{ stack.title }}
</h3>
<h3 v-else-if="!editing"
Expand Down Expand Up @@ -330,8 +329,6 @@ export default {
.stack {
width: $stack-width + $stack-spacing * 3;
margin-left: math.div($stack-spacing, 2);
margin-right: math.div($stack-spacing, 2);
}
.stack__header {
Expand All @@ -340,6 +337,7 @@ export default {
top: 0;
z-index: 100;
padding-left: $card-spacing;
padding-right: $card-spacing;
cursor: grab;
min-height: 44px;
Expand All @@ -351,7 +349,7 @@ export default {
width: 100%;
height: 20px;
top: 30px;
right: 10px;
left: 0px;
z-index: 99;
transition: top var(--animation-slow);
Expand Down
6 changes: 6 additions & 0 deletions src/components/cards/CardItem.vue
Original file line number Diff line number Diff line change
Expand Up @@ -220,6 +220,7 @@ export default {
background-color: var(--color-main-background);
margin-bottom: $card-spacing;
border: 2px solid var(--color-border);
width: 100%;
&:deep(*) {
cursor: pointer;
Expand All @@ -232,6 +233,11 @@ export default {
border: 2px solid var(--color-primary-element);
}
&:focus, &:focus-visible, &:focus-within, &:hover {
outline: none;
border: 2px solid var(--color-primary-element);
}
.card-upper {
display: flex;
min-height: 44px;
Expand Down

0 comments on commit 41d1749

Please sign in to comment.