Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to task processing #97

Merged
merged 57 commits into from
Jul 19, 2024
Merged

Switch to task processing #97

merged 57 commits into from
Jul 19, 2024

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Jul 2, 2024 •
edited
Loading

  • dynamic input/output form generation
  • migrate chattyUI to task processing
  • migrate Context chat to task processing
  • display progress while waiting for a task to complete
  • allow to cancel a running task
  • change the entire image generation logic, allow to share output files
  • refactor the audio recorder
  • many design improvements

@julien-nc
start adding support for task processing API
311b582 
add new notification table, add new endpoint to ask a notification for a task
adjust frontend to new scheduling logic with polling and setNotifyReady
adjust to the real task processing OCP API
support all input field types from task type inputShape
adjust task history list
fix number value being saved as string, start improving canSubmit check, should probably be checking all inputShape fields
use the assistant when the freeprompt picker is opened
use the assistant when the audio transcription picker is opened
use the assistant in the image generation smart picker, share result images, return the share links
implement preview generation for output files
display progress in running empty content

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix overflow, show message on task error
274b1c8 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix failure notification
28e4375 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
allow to cancel a task in the modal while waiting for results
9d95b3e 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
improve style in standalone page
b93ea27 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
migrate chatty UI to the task processing API
358200a 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix loading state after canceling a task
b838504 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fixes #89 sort task types
d638d3a 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
small style improvements
8f283b0 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc added enhancement New feature or request 3. to review labels Jul 2, 2024
marcelklehr
marcelklehr reviewed Jul 2, 2024
View reviewed changes
lib/Controller/ChattyLLMController.php Outdated
$i = 0;
while ($i < 60 && !in_array($task->getStatus(), [Task::STATUS_SUCCESSFUL, Task::STATUS_FAILED, Task::STATUS_CANCELLED])) {
sleep(1);
$task = $this->taskProcessingManager->getTask($task->getId());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, should probably poll in the browser

Copy link
Member Author

@julien-nc julien-nc Jul 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done, both title and message generation are polling now.

marcelklehr
marcelklehr reviewed Jul 2, 2024
View reviewed changes
src/assistant.js Outdated Show resolved Hide resolved
marcelklehr
marcelklehr reviewed Jul 2, 2024
View reviewed changes
src/assistant.js Outdated Show resolved Hide resolved
@marcelklehr
Copy link
Member

PHP part looks good. I'm a bit overwhelmed by the vue.js part :D
I remembered, though, that the files that the task processing manager produces in app data cannot be retrieved by a simple RootFolder#getById(). Not sure if this is relevant for you

@julien-nc
cleanup and start fixing psalm issues
0af253e 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
do not show chattyUI tasks in text2text history
2732ee1 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
cleanup input form from old specific contextwrite stuff
2db2455 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
change style of output text field
b3b66e5 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fixed footer position, expand input/output form and history vertically
f11ba49 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
start moving buttons in text field
ca3e092 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
update npm pkgs
519d432 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix psalm and openapi issues
5c10dc4 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
absolute position of copy and chooseFile buttons in text fields
aed6282 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix more psalm issues and update baseline to ignore remaining ones
088049e 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
change style of number field, remove task type name+desc, add title t…
0303112 
…o task type button in the selector

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
refactor audio recorder
0ba20a0 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
start implementing list of text
a17b0ce 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
start to adjust context chat custom UI to the new task processing pro…
5cdd35f 
…vider

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
finalize context chat custom UI, change how inputs are reset on taskT…
a23b3cf 
…ype change

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
filter out the chat task type
1321b10 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
more design adjustments
0229883 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
more design adjustments
c01dfe4 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
improve media field UX, disable buttons when uploading/recording, cha…
af21951 
…nge labels

Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
adjust list of media field to match media field
a62eaf3 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
move text input label outside, fix copy button overlapping text
7d30404 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
change delete, redo, copy icons
ad4c13b 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix richcontenteditable style issues, make its height smaller
1f9474c 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
add loading icon when chat is thinking, fix conversation header style
e0df3f8 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
fix label of number field
bd553c2 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
improve canSubmit check
02669c6 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
add type validation in number field
39ab774 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
attempt to fix issue when no task type is selected
5041364 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
nothing
4aa7c11 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
polish
52611cb 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
generate OpenAPI specs
c93f43e 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
Copy link
Member Author

PHP part looks good. I'm a bit overwhelmed by the vue.js part :D I remembered, though, that the files that the task processing manager produces in app data cannot be retrieved by a simple RootFolder#getById(). Not sure if this is relevant for you

Yeah I had to replicate what you do in the task processing manager. It works fine.

@julien-nc julien-nc marked this pull request as ready for review July 15, 2024 12:58
@julien-nc
Copy link
Member Author

@marcelklehr Don't worry about the frontend. It's been used for more than a week by people on daily. Anyway it's going to get some more adjustments soon.

marcelklehr
marcelklehr approved these changes Jul 17, 2024
View reviewed changes
Copy link
Member

@marcelklehr marcelklehr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚢

@kyteinsky kyteinsky mentioned this pull request Jul 18, 2024
Merged
@julien-nc
more design adjustments
74958af 
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc merged commit 5da6573 into main Jul 19, 2024
11 checks passed
@julien-nc
Copy link
Member Author

Ui fixes/adjustments can be done in another PR

@julien-nc julien-nc mentioned this pull request Jul 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelklehr marcelklehr marcelklehr approved these changes

Assignees
No one assigned
Labels
3. to review enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@julien-nc @marcelklehr