feat: chatty ui

[kyteinsky]

No description provided.

[julien-nc]

Incredibly nice!
It looks awesome and works super good. Congrats! 💪
I had forgotten you were using the textProcessingManager->runTask so it was such a nice feeling to immediately get the answer after sending my first message. 😁
The instruct being in english does not prevent gpt-3.5-turbo to answer in the same language as the last user message 🎉 I guess/hope it's the same for most LLMs.

Some UI findings:

• The chattyUI expands too much vertically, making the entire modal-container__content overflow and scroll.
  

• It would be nice to have a visual feedback when the LLM answer is being computed. How about a simple loading spinner (NcLoadingIcon for example) where the next message will appear?

• Something goes wrong when regenerating. The last user message (before the assistant message to regenerate) is deleted (from the UI only). It comes back after switching sessions or reloading. This does not happen if one asks to regenerate a message right after loading the session. I can give you more details if needed.

• The instruct prefix is lost when chat_last_n_messages is exceeded. See inline comment in the controller.

[marcelklehr]

At some point it would be nice to migrate to the new Route annotation by kate

[kyteinsky]

We would be losing support for the previous server versions if we do that now. Also, personally I would like to keep this alongside that, if possible, to have a quick look at all the endpoints declared in the app.

[julien-nc]

Additional requirement: Mention in the README the length of the assistant memory (number of messages used to generate a new one). Mention it can be configured with an app config value.

[kyteinsky]

There's no admin docs though, should I create one or just add it to the README in the root dir?

[kyteinsky]

It would be nice to have a visual feedback when the LLM answer is being computed. How about a simple loading spinner (NcLoadingIcon for example) where the next message will appear?

The input box shows the "Thinking" text and there is a breathing animation as well. Maybe it needs to be more prominent. Do you suggest a loading icon in addition to this?

Something goes wrong when regenerating. The last user message (before the assistant message to regenerate) is deleted (from the UI only). It comes back after switching sessions or reloading. This does not happen if one asks to regenerate a message right after loading the session. I can give you more details if needed.

Fixed.

The instruct prefix is lost when chat_last_n_messages is exceeded. See inline comment in the controller.

Fixed.

[julien-nc]

A few more remarks:

• Maybe we can find something better than "session" like "conversation" (which you already use in the NoSession empty content)
• When clicking on "new session", it's not clear that one has to send a first message and THEN a new navigation entry will appear. How about showing a fake "new session" nav item when clicking on "new session"? But then it's not coherent with the initial state (no session selected, empty content displayed)... How about making it like in Talk?
  • Initial empty content says "Join a conversation or start a new one"
  • Click on new session creates a nav entry and the empty content becomes "Hello there! What can I help you with today?"
  • So the session would be created before the first message

[marcelklehr]

There's no admin docs though, should I create one or just add it to the README in the root dir?

Could be done somewhere on this page? https://docs.nextcloud.com/server/latest/admin_manual/ai/app_assistant.html

[marcelklehr]

I guess/hope it's the same for most LLMs.

It isn't, I think.

[marcelklehr]

Unless julien has more comments, I'd say it's good to go

[kyteinsky]

There are a few more tweaks to go, proposed by the design team.

[julien-nc]

With latest server's master, the actions are behind the assistant modal. Do you confirm?

[julien-nc]

It just happens when there is another NcAppNavigation in the page.

[kyteinsky]

nope, pulled server master just now. Works on both chromium and firefox.

[kyteinsky]

It just happens when there is another NcAppNavigation in the page.

yes it does, let me see if z-index or something can do the trick

[kyteinsky]

hmm, I don't even have the popover mounted in my DOM. Can't really point at what's going wrong.

[susnux]

While using the NcAppNavigation outside of the NcContent and within a dialog might work it is not supported usage of the component.

But a real problem here: It must not be used more than once on a page, it will break and even create invalid HTML content of the page. This will also cause any accessibility tests on that page to fail.

Instead the expected solution would probably be either using NcDialog with its native navigation slot (like app settings dialogs):

<NcDialog ...>
  <template #navigation>
    <ul>
      <NcListItem ...>
      <!-- .... -->
    </ul>
  </template>
  <!-- Content -->
</NcDialog>

or using NcModal with a custom content wrapper for layout:

<NcModal>
  <your-content-wrapper>
    <ul class="your-navigation">
      <NcListItem ...>
      <!-- .... -->
    </ul>
    <!-- Other content -->
  </your-content-wrapper>
</NcModal>

[julien-nc]

Psalm failure is caused by missing imports.

[marcelklehr]

Super cool 🎉