Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move STT and image generation to the assistant UI #42

Merged
merged 18 commits into from
Feb 12, 2024

Conversation

julien-nc
Copy link
Member

@julien-nc julien-nc commented Feb 8, 2024

  • Fix image generation result page for non-authenticated users
  • Add an STT task type in the assistant UI and implement a specific input form
  • Add an image generation task type in the assistant UI and implement a specific output field
  • Support STT and image generation in the assistant task result page
  • Use the assistant result page as target for STT and image generation notifications
  • Allow to schedule (instead of runOrSchedule) image generation tasks (when canceling a sync task with the "run in the background" button)
  • Harmonize image generation workflow with the rest: don't show the result widget if it has been scheduled, set notifyReady to true automatically
  • Use @nextcloud/moment instead of humanize-duration for time estimation calculations and human readable display
  • Downgrade @nextcloud/moment to avoid compilation warning
  • Set max height of NcRichContenteditable to 300px, fix top/bottom borders not visible in some cases
  • Set background color of modal close button to make it more visible when it overlaps with content while scrolling

Open questions:

  • In the image gen and STT pickers, should we just use the openAssistantForm function?

Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
…ults, make the notification point to normal assistant result link, allow resubmitting STT task from result page

Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
…ssing scheduling with notification

Signed-off-by: Julien Veyssier <[email protected]>
… run synchronously, tti notification -> open assistant, allow try again for tti

Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc
Copy link
Member Author

This will probably get more polishing and fixes in a future PR.

@julien-nc julien-nc merged commit 734a051 into main Feb 12, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/move-stt-n-igen-to-assistant-ui branch February 12, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant