Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First round of design improvements #38

Merged
merged 26 commits into from
Feb 2, 2024
Merged

First round of design improvements #38

merged 26 commits into from
Feb 2, 2024

Conversation

julien-nc
Copy link
Member

  • Rename "free prompt" to "generate text"
  • Rename "speech to text" to "AI audio transcription"
  • Simplify design of STT recorder
  • Fix accessibility of some buttons
  • Fix keyboard navigation in task type selector
  • Fix style of image generation preview
  • Warn about empty result or if it's identical to the input
  • Change description of the free prompt task type
  • Fix z-index of a modal close button
  • Fix updating input fields when file content is loaded

Signed-off-by: Julien Veyssier <[email protected]>
…g when switching modes

Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
…when task succeded but result is empty

Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
Signed-off-by: Julien Veyssier <[email protected]>
@julien-nc julien-nc added the enhancement New feature or request label Feb 2, 2024
Signed-off-by: Julien Veyssier <[email protected]>
Copy link
Contributor

@MB-Finski MB-Finski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and feels much better!

As a semi-related thought; maybe adding "align-items: center;" in the Text2ImageCustomPickerElement .image-preview would make sense? Currently the image display is centered everywhere else but not in the picker itself.

BTW the bug related to output resetting still exists in gptfreeprompt but is not reproducible in assistant; like we discussed the more up-to-date libs probably explain that.

@julien-nc
Copy link
Member Author

@MB-Finski Good point. I went all the way and unified the style of the image previews everywhere.
The width of Text2ImageDisplay is not defined in the component itself anymore but rather at each place it is used.
There's now a border around the preview in the preview page just like in other places.
The preview container in the picker is now full width so it aligns with the rest.
Wdyt of all that?

@julien-nc julien-nc merged commit 5e135bc into main Feb 2, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the enh/design branch February 2, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants