BugFix - Don't Use File Download Worker for Two Way Sync #13993
Merged
+95
−26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
1 task
|
/backport to stable-3.30 |
app/src/main/java/com/owncloud/android/operations/SynchronizeFileOperation.java
Show resolved
Hide resolved
app/src/main/java/com/owncloud/android/operations/SynchronizeFolderOperation.java
Outdated
Show resolved
Hide resolved
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
app/src/main/java/com/owncloud/android/operations/SynchronizeFolderOperation.java
Show resolved
Hide resolved
Signed-off-by: alperozturk <[email protected]>
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
tobiasKaminsky
approved these changes
Nov 11, 2024
tobiasKaminsky
deleted the
bugfix/dont-use-file-download-worker-for-two-way-sync
branch
|
@tobiasKaminsky @alperozturk96 breaks FileIT test with a compile error |
FjPlays
pushed a commit
to FjPlays/android
that referenced
this pull request
Nov 12, 2024
…e-download-worker-for-two-way-sync BugFix - Don't Use File Download Worker for Two Way Sync
Should be resolved with #13998. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Use FileDownloadWorker only for manual sync to ensure that notifications for downloads do not disappear. Additionally, observe the sync status in the adapter, and ensure the cancellation functionality for sync is not broken after these changes for Two-Way-Sync
Add operation?.cancel() in the onStopped() method to improve cancellation handling through SynchronizeFolderOperations