BugFix - Sync Nested Folder #13974
Open
BugFix - Sync Nested Folder #13974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alperozturk96
force-pushed
the
bugfix/sync-nested-folders
branch
from
ba05f94
to
aa1537f
Compare
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
bugfix/sync-nested-folders
branch
from
aa1537f
to
aebd7bb
Compare
|
blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13974-Screenshot-blue-Light-12-17 |
| @@ -414,23 +413,21 @@ private void classifyFileForLaterSyncOrDownload(OCFile remoteFile, OCFile localF | |||
|
|
|||
|
|
|||
| private void prepareOpsFromLocalKnowledge() throws OperationCancelledException { | |||
| List<OCFile> children = getStorageManager().getFolderContent(mLocalFolder, false); | |||
| List<OCFile> children = getStorageManager().getAllFilesRecursivelyInsideFolder(mLocalFolder); | |||
There was a problem hiding this comment.
If we want to have nested folder sync, we should start with SynchronizeFolderOperation on folders, but not only on files.
tobiasKaminsky
requested changes
Nov 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
How to Test?
The sync folder action should sync all files within the selected folder, not just those one level below.