Feature - Add More MDM

[alperozturk96]

• Tests written, or not not needed

How to Test?

1. Modify the relevant settings in setup.xml, and ensure the app responds appropriately to the updated conditions.
2. Verify if conditions. It must behave as expected.
3. Test both MDM-related variables and legacy variables in combination to confirm compatibility.

Disable Multi Account -- User can't add account. New accounts can’t be added from the Manage Account section.

Disable Sharing -- Removes share button from action list

Disable More External Site -- Removes external sites from drawer menu

Disable Intro -- Don't launch FirstRunActivity only if user not logged in before

disable_intro.mp4

[tobiasKaminsky]

MDMConfig.kt -> shareVia Link -> return false, but I can still see it in details:

Same is true for "shareViaUser"

[tobiasKaminsky]

sendFilesSupport -> false
but you can still click on "+person" icon on a file in file list to trigger sharing dialog:

[alperozturk96]

@tobiasKaminsky In rare cases, context can be null. In that case, onClick of AddAccountViewHolderItem will do nothing. Is it expected behavior?

[tobiasKaminsky]

Not sure. But this should be independant from this PR?
So, create a new issue and we can check/discuss.

[tobiasKaminsky]

Disable clipboard should also hide clipboard icon.
Otherwise user might think it is just broken.

[alperozturk96]

sendFilesSupport -> false but you can still click on "+person" icon on a file in file list to trigger sharing dialog:

I’ve updated the PR. I believe the correct condition is: if any of the functions—shareViaUser, shareViaLink, or sendFilesSupport—returns false, we should hide the icon, right?

[tobiasKaminsky]

I’ve updated the PR. I believe the correct condition is: if any of the functions—shareViaUser, shareViaLink, or sendFilesSupport—returns false, we should hide the icon, right?

yes. MDM is to disable sharing/send files/clipboard

So for MDM there is no need to have those 3 functions. But as this is already in place in our code, just combine those for MDM.

[alperozturk96]

I’ve updated the PR. I believe the correct condition is: if any of the functions—shareViaUser, shareViaLink, or sendFilesSupport—returns false, we should hide the icon, right?

yes. MDM is to disable sharing/send files/clipboard

So for MDM there is no need to have those 3 functions. But as this is already in place in our code, just combine those for MDM.

43dc61f

[tobiasKaminsky]

Still sharing, but "details" as headline?

[tobiasKaminsky]

Share via link:

• internal link share still should be shown (as this is not a real share)

sendFilesSupport:

• still can send it to another app
• also possible to see "DocumentStorageProvider" in Android's Files app

Rest ✔

[github-actions]

blue-Light-Screenshot test failed: https://www.kaminsky.me/nc-dev/android-integrationTests/13942-Screenshot-blue-Light-16-50

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	59	59
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	65	65
Correctness	61	61
Dodgy code	298	298
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	7	7
Performance	53	53
Security	18	18
Total	511	511