BugFix - NPE internalFolderSyncTimestamp & File Existence Check #13612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 24, 2024
This was referenced Sep 24, 2024
|
Thank you! This fixed it for me. |
alperozturk96
changed the title
alperozturk96
force-pushed
the
bugfix/npe-isInternalFolderSync
branch
from
8b43e4f
to
d81ddfd
Compare
AndyScherzinger
approved these changes
Sep 25, 2024
app/src/main/java/com/nextcloud/client/jobs/InternalTwoWaySyncWork.kt
Outdated
Show resolved
Hide resolved
alperozturk96
force-pushed
the
bugfix/npe-isInternalFolderSync
branch
from
d81ddfd
to
26cbf21
Compare
|
Draft or ready to review? 🙈 |
|
@tobiasKaminsky We have to test two-way sync properly before merge this PR, so it's a draft. |
alperozturk96
force-pushed
the
bugfix/npe-isInternalFolderSync
branch
from
26cbf21
to
7c00ab2
Compare
alperozturk96
added
2. developing
3. to review
and removed
3. to review
2. developing
labels
Open
…ullable value Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
Signed-off-by: alperozturk <[email protected]>
alperozturk96
force-pushed
the
bugfix/npe-isInternalFolderSync
branch
from
51fbb8f
to
f90daae
Compare
Signed-off-by: alperozturk <[email protected]>
|
Hello, can you publish this fix as quickly as possible in the Fdroid repository via an update? How long will the waiting time be? |
AndyScherzinger
approved these changes
Oct 2, 2024
tobiasKaminsky
approved these changes
Oct 4, 2024
|
/backport to stable-3.30 |
Is this fix now available on Fdroid? |
|
Can we expect information updates on the release of this fix to the production app? Currently the fdroid version is 3.30.0 so I guess the fix is not there. Gplay version is 3.29.x so I don't know if it has the issue. I know how these kinds of questions are annoying but the issue is rendering the app pretty difficult to use. |
This was referenced Oct 20, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
During my tests, I wasn’t able to reproduce the issue; however, some users with version 3.30.0 Final have already experienced the crash. It means some OCFile already saved into the internal storage via null value.
Potential fix could be in this PR:
Changing following set function, but I’m not sure.
ocFile.setInternalFolderSyncTimestamp(fileEntity.getInternalTwoWaySync()); ->
ocFile.setInternalFolderSyncTimestamp(nullToZero(fileEntity.getInternalTwoWaySync()));
To prevent further crashes, I checked nullability of the Long object and return non-null object. Alternative solution can be we can convert the Long object to long primitive type.