File Name Validator Improvements

[alperozturk96]

• Tests written, or not not needed

not valid anymore. The community has already approved the first version

[ZetaTom]

@alperozturk96, first of all, my review is not invalidated because someone else has approved something. In fact, it is still valid, as the concerns raised in my comments still hold true.

To prove my point, I'll elaborate: as the string is set with this pull request, it suggests that no spaces shall be contained in any filename. This is a valid interpretation of A space character is not allowed in file names.

Obviously this isn't true, as you can still have a file called This Filename Contains Spaces.md. Because this is a perfectly valid filename, I would suggest rephrasing this sentence to reflect the real problem, the trailing spaces. So I suggested the following phrase instead: Filenames must not contain any trailing spaces, as this accurately reflects the problem and tells the user how to fix it.

So I ask you to please, simply, reconsider my review.

[alperozturk96]

@ZetaTom I think your suggestion touches on another detail and is not quite right. Because "Filenames must not contain any trailing or leading spaces" not just trailing.

Feedback was received from the “Mobile apps public” (Transifex) channel regarding the mentioned translations, and their current versions were accepted.

I have no problem with either the translations you suggested or the previously approved translations. Both are suitable for me. There is an approved translation in place, and we need to consult the translators again based on your suggestion. Because the first approval was based on another translation, it would be more appropriate to ask them to review again for the new translation.

I don’t find it appropriate to portray even a single translation as a major issue. I cannot have back-and-forth exchanges between you and the translators. Such attitudes only slow us down and contribute negatively rather than positively. I don’t think engaging in lengthy arguments here will be beneficial.

As previously mentioned, I don’t believe the initial suggestion would be a massive problem for users. And I would say the most recent suggestion improves the original translation. @rakekniven @tobiasKaminsky

[rakekniven]

I adapted this single change and kindly ask for merging.

[github-actions]

Codacy

Lint

Type	master	PR
Warnings	59	59
Errors	3	3

SpotBugs

Category	Base	New
Bad practice	64	64
Correctness	63	63
Dodgy code	297	297
Experimental	1	1
Internationalization	7	7
Malicious code vulnerability	1	1
Multithreaded correctness	6	6
Performance	53	53
Security	18	18
Total	510	510

[github-actions]

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/13577.apk



To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud app.

[AndyScherzinger]

/backport to stable-3.30